Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(138)

Unified Diff: tools/generate_dump.cc

Issue 1303173011: win: Implement and use ScopedProcessSuspend (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: dword -1 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « handler/win/crash_report_exception_handler.cc ('k') | util/util.gyp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/generate_dump.cc
diff --git a/tools/generate_dump.cc b/tools/generate_dump.cc
index 5da9f044196073ef0142c875f0000706fb3c238e..f68c17c2a068be8a356d2fb29d41a45711d11106 100644
--- a/tools/generate_dump.cc
+++ b/tools/generate_dump.cc
@@ -41,6 +41,7 @@
#elif defined(OS_WIN)
#include "base/strings/utf_string_conversions.h"
#include "snapshot/win/process_snapshot_win.h"
+#include "util/win/scoped_process_suspend.h"
#endif // OS_MACOSX
namespace crashpad {
@@ -168,9 +169,9 @@ int GenerateDumpMain(int argc, char* argv[]) {
suspend.reset(new ScopedTaskSuspend(task));
}
#elif defined(OS_WIN)
+ scoped_ptr<ScopedProcessSuspend> suspend;
if (options.suspend) {
- LOG(ERROR) << "TODO(scottmg): --no-suspend is required for now.";
- return EXIT_FAILURE;
+ suspend.reset(new ScopedProcessSuspend(process.get()));
}
#endif // OS_MACOSX
« no previous file with comments | « handler/win/crash_report_exception_handler.cc ('k') | util/util.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698