Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(308)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: handler/win/crash_report_exception_handler.cc

Issue 1303173011: win: Implement and use ScopedProcessSuspend (Closed) Base URL: https://chromium.googlesource.com/crashpad/crashpad@master
Patch Set: dword -1 Created 5 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/generate_dump.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: handler/win/crash_report_exception_handler.cc
diff --git a/handler/win/crash_report_exception_handler.cc b/handler/win/crash_report_exception_handler.cc
index faf03671e230865b4ab9a53d5b924cf431738820..69df244f7f9e0c5c3d81058cff57d084c6c38e79 100644
--- a/handler/win/crash_report_exception_handler.cc
+++ b/handler/win/crash_report_exception_handler.cc
@@ -21,6 +21,7 @@
#include "snapshot/win/process_snapshot_win.h"
#include "util/file/file_writer.h"
#include "util/win/registration_protocol_win.h"
+#include "util/win/scoped_process_suspend.h"
namespace crashpad {
@@ -44,7 +45,7 @@ unsigned int CrashReportExceptionHandler::ExceptionHandlerServerException(
WinVMAddress exception_information_address) {
const unsigned int kFailedTerminationCode = 0xffff7002;
- // TODO(scottmg): ScopedProcessSuspend
+ ScopedProcessSuspend suspend(process);
ProcessSnapshotWin process_snapshot;
if (!process_snapshot.Initialize(process)) {
« no previous file with comments | « no previous file | tools/generate_dump.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698