win: Implement and use ScopedProcessSuspend

util/win/scoped_process_suspend_test.cc

Index: util/win/scoped_process_suspend_test.cc
diff --git a/util/win/scoped_process_suspend_test.cc b/util/win/scoped_process_suspend_test.cc
new file mode 100644
index 0000000000000000000000000000000000000000..b521671bf44bad1e8aeed7fc3daa2c296ef55392
--- /dev/null
+++ b/util/win/scoped_process_suspend_test.cc
@@ -0,0 +1,106 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/win/scoped_process_suspend.h"
+
+#include <tlhelp32.h>
+
+#include <algorithm>
+#include <vector>
+
+#include "gtest/gtest.h"
+#include "test/win/win_child_process.h"
+
+namespace crashpad {
+namespace test {
+namespace {
+
+// There is no per-process suspend count on Windows, only a per-thread suspend
+// count. NtSuspendProcess just suspends all threads of a given process. So,
+// verify that all thread's suspend counts match the desired suspend count.
+bool SuspendCountMatches(HANDLE process, DWORD desired_suspend_count) {
+  DWORD process_id = GetProcessId(process);
+
+  ScopedKernelHANDLE snapshot(CreateToolhelp32Snapshot(TH32CS_SNAPTHREAD, 0));
+  if (!snapshot.is_valid())
+    return false;
+
+  THREADENTRY32 te;
+  te.dwSize = sizeof(te);
+  if (!Thread32First(snapshot.get(), &te))
+    return false;
+  do {
+    if (te.dwSize >= offsetof(THREADENTRY32, th32OwnerProcessID) +
+                         sizeof(te.th32OwnerProcessID) &&
+        te.th32OwnerProcessID == process_id) {
+      ScopedKernelHANDLE thread(
+          OpenThread(THREAD_ALL_ACCESS, false, te.th32ThreadID));
+      DWORD result = SuspendThread(thread.get());
+      EXPECT_NE(result, 0xffffffff);
+      if (result >= 0)

[Mark Mentovai, 2015/09/05 00:15:43]

result is a DWORD which is an unsigned long, right?

[scottmg, 2015/09/08 16:06:43]

Good catch, thanks. Done.

+        ResumeThread(thread.get());
+      if (result != desired_suspend_count)
+        return false;
+    }
+    te.dwSize = sizeof(te);
+  } while (Thread32Next(snapshot.get(), &te));
+
+  return true;
+}
+
+class ScopedProcessSuspendTest final : public WinChildProcess {
+ public:
+  ScopedProcessSuspendTest() : WinChildProcess() {}
+  ~ScopedProcessSuspendTest() {}
+
+ private:
+  int Run() override {
+    char c;
+    // Wait for notification from parent.
+    EXPECT_TRUE(LoggingReadFile(ReadPipeHandle(), &c, sizeof(c)));
+    EXPECT_EQ(' ', c);
+    return EXIT_SUCCESS;
+  }
+
+  DISALLOW_COPY_AND_ASSIGN(ScopedProcessSuspendTest);
+};
+
+TEST(ScopedProcessSuspend, ScopedProcessSuspend) {
+  WinChildProcess::EntryPoint<ScopedProcessSuspendTest>();
+  scoped_ptr<WinChildProcess::Handles> handles = WinChildProcess::Launch();
+
+  EXPECT_TRUE(SuspendCountMatches(handles->process.get(), 0));
+
+  {
+    ScopedProcessSuspend suspend(handles->process.get());
+    EXPECT_TRUE(SuspendCountMatches(handles->process.get(), 1));
+
+    {
+      ScopedProcessSuspend suspend(handles->process.get());
+      EXPECT_TRUE(SuspendCountMatches(handles->process.get(), 2));
+    }
+
+    EXPECT_TRUE(SuspendCountMatches(handles->process.get(), 1));
+  }
+
+  EXPECT_TRUE(SuspendCountMatches(handles->process.get(), 0));
+
+  // Tell the child it's OK to terminate.
+  char c = ' ';
+  EXPECT_TRUE(WriteFile(handles->write.get(), &c, sizeof(c)));
+}
+
+}  // namespace
+}  // namespace test
+}  // namespace crashpad