win: Implement and use ScopedProcessSuspend

util/win/scoped_process_suspend.cc

Index: util/win/scoped_process_suspend.cc
diff --git a/util/win/scoped_process_suspend.cc b/util/win/scoped_process_suspend.cc
new file mode 100644
index 0000000000000000000000000000000000000000..4450efb5256085627ce8f0c3343daad2c5ed7b78
--- /dev/null
+++ b/util/win/scoped_process_suspend.cc
@@ -0,0 +1,41 @@
+// Copyright 2015 The Crashpad Authors. All rights reserved.
+//
+// Licensed under the Apache License, Version 2.0 (the "License");
+// you may not use this file except in compliance with the License.
+// You may obtain a copy of the License at
+//
+//     http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+#include "util/win/scoped_process_suspend.h"
+
+#include <winternl.h>
+
+#include "base/logging.h"
+
+namespace crashpad {
+
+ScopedProcessSuspend::ScopedProcessSuspend(HANDLE process) : process_(process) {
+  typedef NTSTATUS(__stdcall * NtSuspendProcessFunc)(HANDLE);
+  static NtSuspendProcessFunc func = reinterpret_cast<NtSuspendProcessFunc>(
+      GetProcAddress(GetModuleHandle(L"ntdll.dll"), "NtSuspendProcess"));
+  NTSTATUS status = func(process_);
+  if (status)
+    LOG(ERROR) << "NtSuspendProcess, ntstatus=" << status;

[Mark Mentovai, 2015/09/05 00:15:43]

I’ve probably said so before, but this would be a good use for NTSTATUS_LOG(),
and a “git grep” shows that maybe we’ve reached the point where it’d be
worthwhile.

See MACH_LOG() (base/mac/mach_logging.h) and OSSTATUS_LOG()
(base/mac/mac_logging.h, but not in mini_chromium).

This suggestion is only food for thought for a follow-up, not for this change at
all.

[scottmg, 2015/09/08 16:06:43]

Yeah, that sounds like a good idea.

+}
+
+ScopedProcessSuspend::~ScopedProcessSuspend() {
+  typedef NTSTATUS(__stdcall * NtResumeProcessFunc)(HANDLE);
+  static NtResumeProcessFunc func = reinterpret_cast<NtResumeProcessFunc>(
+      GetProcAddress(GetModuleHandle(L"ntdll.dll"), "NtResumeProcess"));
+  NTSTATUS status = func(process_);
+  if (status)
+    LOG(ERROR) << "NtResumeProcess, ntstatus=" << status;
+}
+
+}  // namespace crashpad