Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Issue 1303173002: Move computeInlineBoxPosition() to VisibleUnits.{cpp,h} from Position.{cpp,h} and VisiblePosition.h (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move computeInlineBoxPosition() to VisibleUnits.{cpp,h} from Position.{cpp,h} and VisiblePosition.h This patch moves |computeInlineBoxPosition()| to "VisibleUnits.{cpp,h} from "Position.{cpp,h}" and "VisiblePosition.{cpp,h}" to consolidate |InlineBox| dependency to "VisibleUnits.cpp" for ease of working them later. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200970

Patch Set 1 : 2015-08-21T13:45:14 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+278 lines, -284 lines) Patch
M Source/core/editing/Position.h View 2 chunks +0 lines, -27 lines 0 comments Download
M Source/core/editing/Position.cpp View 1 chunk +0 lines, -250 lines 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/editing/VisiblePosition.h View 1 chunk +0 lines, -7 lines 0 comments Download
M Source/core/editing/VisibleUnits.h View 2 chunks +22 lines, -0 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +255 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-21 05:11:29 UTC) #2
yoichio
lgtm
5 years, 4 months ago (2015-08-21 07:01:10 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303173002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303173002/1
5 years, 4 months ago (2015-08-21 07:24:29 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 07:29:34 UTC) #6
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200970

Powered by Google App Engine
This is Rietveld 408576698