Move computeInlineBoxPosition() to VisibleUnits.{cpp,h} from Position.{cpp,h} and VisiblePosition.h

Source/core/editing/Position.h

 /*
  * Copyright (C) 2004, 2006, 2008 Apple Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
  * 2. Redistributions in binary form must reproduce the above copyright
  *    notice, this list of conditions and the following disclaimer in the
@@ skipping 21 matching lines @@
 #include "core/editing/EditingStrategy.h"
 #include "platform/heap/Handle.h"
 #include "platform/text/TextDirection.h"
 #include "wtf/Assertions.h"
 #include "wtf/PassRefPtr.h"
 #include "wtf/RefPtr.h"
 
 namespace blink {
 
 class Element;
-class InlineBox;
 class Node;
 class LayoutObject;
 class Text;
 enum class TextAffinity;
 class TreeScope;
 
-struct InlineBoxPosition {
-    InlineBox* inlineBox;
-    int offsetInBox;
-
-    InlineBoxPosition()
-        : inlineBox(nullptr), offsetInBox(0)
-    {
-    }
-
-    InlineBoxPosition(InlineBox* inlineBox, int offsetInBox)
-        : inlineBox(inlineBox), offsetInBox(offsetInBox)
-    {
-    }
-};
-
 enum PositionMoveType {
     CodePoint, // Move by a single code point.
     Character, // Move to the next Unicode character break.
     BackwardDeletion // Subject to platform conventions.
 };
 
 enum class PositionAnchorType : unsigned {
     OffsetInAnchor,
     BeforeAnchor,
     AfterAnchor,
@@ skipping 342 matching lines @@
 {
     return position;
 }
 
 template <>
 inline PositionInComposedTree fromPositionInDOMTree<EditingInComposedTreeStrategy>(const Position& position)
 {
     return toPositionInComposedTree(position);
 }
 
-// TODO(yosin) |isRenderedCharacter()| should be removed, and we should use
-// |VisiblePosition::characterAfter()| and |VisiblePosition::characterBefore()|.
-// TODO(yosin) We should move |isRenderedCharacter()| to "VisibleUnits.cpp",
-// since it is used only in "editing/commands/"
-CORE_EXPORT bool isRenderedCharacter(const Position&);
-// TODO(yosin) We should move |computeInlineBoxPosition()| to "VisibleUnits.cpp"
-CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const Position&, TextAffinity);
-CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const Position&, TextAffinity, TextDirection primaryDirection);
-CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const PositionInComposedTree&, TextAffinity);
-CORE_EXPORT InlineBoxPosition computeInlineBoxPosition(const PositionInComposedTree&, TextAffinity, TextDirection primaryDirection);
-
 // TODO(yosin) We should move |inRenderedText()| to "VisibleUnits.h" for
 // reduce dependency of |LayoutObject| in |Position| class.
 CORE_EXPORT bool inRenderedText(const Position&);
 CORE_EXPORT bool inRenderedText(const PositionInComposedTree&);
 
 CORE_EXPORT int uncheckedPreviousOffset(const Node*, int current);
 CORE_EXPORT int uncheckedNextOffset(const Node*, int current);
 
 // TODO(yosin) We should move |isVisuallyEquivalentCandidate()| to
 // "VisibleUnits.cpp" to reduce |LayoutObject| dependency in "Position.cpp".
 CORE_EXPORT bool isVisuallyEquivalentCandidate(const Position&);
 CORE_EXPORT bool isVisuallyEquivalentCandidate(const PositionInComposedTree&);
 
 } // namespace blink
 
 #ifndef NDEBUG
 // Outside the WebCore namespace for ease of invocation from gdb.
 void showTree(const blink::Position&);
 void showTree(const blink::Position*);
 #endif
 
 #endif // Position_h