Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(105)

Issue 1303053004: Revert of Vector ICs: platform support for vector-based stores. (Closed)

Created:
5 years, 3 months ago by Michael Achenbach
Modified:
5 years, 3 months ago
CC:
v8-dev, v8-mips-ports_googlegroups.com, rmcilroy
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of Vector ICs: platform support for vector-based stores. (patchset #7 id:120001 of https://codereview.chromium.org/1328603003/ ) Reason for revert: [Sheriff] Breaks compile on arm: http://build.chromium.org/p/client.v8/builders/V8%20Arm%20-%20builder/builds/6590 Original issue's description: > Vector ICs: platform support for vector-based stores. > > The last changes for vector store functionality, they are in 3 areas: > > 1) The new vector [keyed] store code stubs - implementation. > 2) IC and handler compiler adjustments > 3) Odds and ends. A change in ast.cc, a test update, a small Oracle fix. > > BUG= > > Committed: https://crrev.com/63af1b3aec6547e7cdf502666ff79c562de8b679 > Cr-Commit-Position: refs/heads/master@{#30570} TBR=bmeurer@chromium.org,jkummerow@chromium.org,mvstanton@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/d51c588524a2255d7c7b4f7aecab2c5a055f4e1b Cr-Commit-Position: refs/heads/master@{#30571}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+192 lines, -1510 lines) Patch
M src/arm/code-stubs-arm.cc View 3 chunks +7 lines, -170 lines 0 comments Download
M src/arm64/code-stubs-arm64.cc View 2 chunks +6 lines, -155 lines 0 comments Download
M src/ast.cc View 1 chunk +1 line, -3 lines 0 comments Download
M src/ia32/code-stubs-ia32.cc View 2 chunks +2 lines, -300 lines 0 comments Download
M src/ic/access-compiler.h View 1 chunk +3 lines, -0 lines 0 comments Download
M src/ic/arm/access-compiler-arm.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm/handler-compiler-arm.cc View 2 chunks +8 lines, -19 lines 0 comments Download
M src/ic/arm/ic-arm.cc View 3 chunks +7 lines, -19 lines 0 comments Download
M src/ic/arm/ic-compiler-arm.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/ic/arm/stub-cache-arm.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/ic/arm64/access-compiler-arm64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/arm64/handler-compiler-arm64.cc View 2 chunks +9 lines, -19 lines 0 comments Download
M src/ic/arm64/ic-arm64.cc View 3 chunks +7 lines, -9 lines 0 comments Download
M src/ic/arm64/ic-compiler-arm64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/ic/arm64/stub-cache-arm64.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/ic/ia32/access-compiler-ia32.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/ia32/handler-compiler-ia32.cc View 5 chunks +12 lines, -31 lines 0 comments Download
M src/ic/ia32/ic-compiler-ia32.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/ic/ia32/ic-ia32.cc View 3 chunks +5 lines, -21 lines 0 comments Download
M src/ic/ia32/stub-cache-ia32.cc View 3 chunks +19 lines, -31 lines 0 comments Download
M src/ic/mips/access-compiler-mips.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips/handler-compiler-mips.cc View 2 chunks +8 lines, -19 lines 0 comments Download
M src/ic/mips/ic-compiler-mips.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/ic/mips/ic-mips.cc View 3 chunks +6 lines, -8 lines 0 comments Download
M src/ic/mips/stub-cache-mips.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/ic/mips64/access-compiler-mips64.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/ic/mips64/handler-compiler-mips64.cc View 2 chunks +8 lines, -19 lines 0 comments Download
M src/ic/mips64/ic-compiler-mips64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/ic/mips64/ic-mips64.cc View 3 chunks +9 lines, -12 lines 0 comments Download
M src/ic/mips64/stub-cache-mips64.cc View 1 chunk +2 lines, -8 lines 0 comments Download
M src/ic/x64/access-compiler-x64.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/ic/x64/handler-compiler-x64.cc View 4 chunks +9 lines, -24 lines 0 comments Download
M src/ic/x64/ic-compiler-x64.cc View 1 chunk +1 line, -4 lines 0 comments Download
M src/ic/x64/ic-x64.cc View 3 chunks +3 lines, -11 lines 0 comments Download
M src/ic/x64/stub-cache-x64.cc View 1 chunk +3 lines, -10 lines 0 comments Download
M src/mips/code-stubs-mips.cc View 2 chunks +6 lines, -167 lines 0 comments Download
M src/mips64/code-stubs-mips64.cc View 2 chunks +6 lines, -162 lines 0 comments Download
M src/type-info.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/type-info.cc View 1 chunk +2 lines, -2 lines 0 comments Download
M src/x64/code-stubs-x64.cc View 2 chunks +6 lines, -148 lines 0 comments Download
M test/cctest/test-feedback-vector.cc View 5 chunks +19 lines, -87 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
Created Revert of Vector ICs: platform support for vector-based stores.
5 years, 3 months ago (2015-09-03 17:43:48 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1303053004/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1303053004/1
5 years, 3 months ago (2015-09-03 17:44:04 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-03 17:44:23 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-03 17:44:42 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/d51c588524a2255d7c7b4f7aecab2c5a055f4e1b
Cr-Commit-Position: refs/heads/master@{#30571}

Powered by Google App Engine
This is Rietveld 408576698