[es6] Remaining cases of parameter scopes for sloppy eval

[es6] Remaining cases of parameter scopes for sloppy eval

R=littledan@chromium.org
BUG=

Committed: https://crrev.com/089592ad33754e70d2d2ccf827682d97c79689ae
Cr-Commit-Position: refs/heads/master@{#30363}

[rossberg, 2015-08-25 08:06:34]

Friendly ping.

[Dan Ehrenberg, 2015-08-25 20:18:12]

lgtm

https://codereview.chromium.org/1303013007/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1303013007/diff/1/src/parser.cc#newcode4390
src/parser.cc:4390: CheckConflictingVarDeclarations(param_scope, CHECK_OK);
Not new in this patch, but I'm wondering why we check this when it's a new
declaration scope that's introduced. I don't see how you could come up with a
conflict now, but with do-expressions I could imagine it, and that var
declaration should just not be visible anywhere after the parameters are
evaluated.

[rossberg, 2015-08-25 21:58:41]

https://codereview.chromium.org/1303013007/diff/1/src/parser.cc
File src/parser.cc (right):

https://codereview.chromium.org/1303013007/diff/1/src/parser.cc#newcode4390
src/parser.cc:4390: CheckConflictingVarDeclarations(param_scope, CHECK_OK);
On 2015/08/25 20:18:12, Dan Ehrenberg wrote:
> Not new in this patch, but I'm wondering why we check this when it's a new
> declaration scope that's introduced. I don't see how you could come up with a
> conflict now, but with do-expressions I could imagine it, and that var
> declaration should just not be visible anywhere after the parameters are
> evaluated.

Indeed, I did this with do-expressions in mind. Seemed "more correct" now, and
one thing less to overlook later. :)

[rossberg, 2015-08-25 21:58:46]

The CQ bit was checked by rossberg@chromium.org

[commit-bot: I haz the power, 2015-08-25 21:58:56]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1303013007/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1303013007/1

[commit-bot: I haz the power, 2015-08-25 22:24:23]

Committed patchset #1 (id:1)

[commit-bot: I haz the power, 2015-08-25 22:24:41]

Patchset 1 (id:??) landed as
https://crrev.com/089592ad33754e70d2d2ccf827682d97c79689ae
Cr-Commit-Position: refs/heads/master@{#30363}