src/parser.h - Issue 1303013007: [es6] Remaining cases of parameter scopes for sloppy eval

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/parser.h

Issue 1303013007: [es6] Remaining cases of parameter scopes for sloppy eval (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/parser.h

diff --git a/src/parser.h b/src/parser.h

index 602b5278ea813cb20083df5e99465c7466975abd..355778b042d3368b3f340cc58f08a357bc7879a4 100644

--- a/src/parser.h

+++ b/src/parser.h

@@ -546,6 +546,9 @@ struct ParserFormalParameters : FormalParametersBase {

Expression* pattern;

Expression* initializer;

bool is_rest;

+ bool is_simple() const {

+ return pattern->IsVariableProxy() && initializer == nullptr && !is_rest;

+ }

};

explicit ParserFormalParameters(Scope* scope)

« no previous file with comments | « no previous file | src/parser.cc » ('j') | src/parser.cc » ('J')