Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Issue 1302713002: Move computeInlineBoxPosition() out from VisiblePosition (Closed)

Created:
5 years, 4 months ago by yosin_UTC9
Modified:
5 years, 4 months ago
Reviewers:
yoichio, hajimehoshi
CC:
blink-reviews
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Move computeInlineBoxPosition() out from VisiblePosition This patch moves |computeInlineBoxPosition()| out from |VisiblePosition| for a preparation of moving |computeInlineBoxPosition()| out from |Position| to make |Position| class simpler for improving code health. BUG=518738 TEST=n/a; no behavior changes Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200809

Patch Set 1 : 2015-08-19T13:39:17 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -10 lines) Patch
M Source/core/editing/FrameSelection.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/editing/RenderedPosition.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/VisiblePosition.h View 2 chunks +7 lines, -5 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 10 (4 generated)
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302713002/1
5 years, 4 months ago (2015-08-19 04:42:56 UTC) #2
yosin_UTC9
PTAL
5 years, 4 months ago (2015-08-19 04:54:09 UTC) #4
hajimehoshi
lgtm
5 years, 4 months ago (2015-08-19 05:08:07 UTC) #5
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
5 years, 4 months ago (2015-08-19 08:01:11 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302713002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302713002/1
5 years, 4 months ago (2015-08-19 08:33:26 UTC) #9
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 08:37:37 UTC) #10
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200809

Powered by Google App Engine
This is Rietveld 408576698