Source/core/editing/FrameSelection.cpp - Issue 1302713002: Move computeInlineBoxPosition() out from VisiblePosition

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/FrameSelection.cpp

Issue 1302713002: Move computeInlineBoxPosition() out from VisiblePosition (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-19T13:39:17 Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: Source/core/editing/FrameSelection.cpp

diff --git a/Source/core/editing/FrameSelection.cpp b/Source/core/editing/FrameSelection.cpp

index 56a502bc46f655ee436646c7f527f5c59a85e055..c2b3e2aea50bb0b9edb6114e33645e35c43bd075 100644

--- a/Source/core/editing/FrameSelection.cpp

+++ b/Source/core/editing/FrameSelection.cpp

@@ -528,9 +528,9 @@ TextDirection FrameSelection::directionOfSelection()

VisiblePosition startPosition = m_selection.visibleStart();

VisiblePosition endPosition = m_selection.visibleEnd();

if (startPosition.isNotNull())

- startBox = startPosition.computeInlineBoxPosition().inlineBox;

+ startBox = computeInlineBoxPosition(startPosition).inlineBox;

if (endPosition.isNotNull())

- endBox = endPosition.computeInlineBoxPosition().inlineBox;

+ endBox = computeInlineBoxPosition(endPosition).inlineBox;

if (startBox && endBox && startBox->direction() == endBox->direction())

return startBox->direction();

« no previous file with comments | « no previous file | Source/core/editing/RenderedPosition.cpp » ('j') | no next file with comments »