Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1)

Issue 1302533002: Native context: debug.js does not load from js builtins object anymore. (Closed)

Created:
5 years, 4 months ago by Yang
Modified:
5 years, 4 months ago
Reviewers:
Camillo Bruni
CC:
v8-dev, Yang
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Native context: debug.js does not load from js builtins object anymore. This mainly changes how we share ToBoolean, ToNumber and ToString between native scripts. Instead of putting them on the js builtins object, we now explicitly export and import those functions. I also had to change the import/export mechanism slightly. Previously, exports and imports are hooked up after all native scripts have been executed. This means that imported functions cannot be called at the time the native script is executed. However, since ToBoolean (and also e.g. ObjectDefineProperties) is called in v8natives.js, I changed the mechanism so that exports from previous native scripts (runtime.js for ToBoolean) is imported immediately and can be called. R=cbruni@chromium.org Committed: https://crrev.com/eb8c092822c7745b49d3d97ec93edc2b0af72827 Cr-Commit-Position: refs/heads/master@{#30244}

Patch Set 1 #

Patch Set 2 : make importing requirement more explicit #

Unified diffs Side-by-side diffs Delta from patch set Stats (+299 lines, -223 lines) Patch
M src/array.js View 5 chunks +9 lines, -6 lines 0 comments Download
M src/arraybuffer.js View 1 chunk +2 lines, -1 line 0 comments Download
M src/date.js View 20 chunks +58 lines, -55 lines 0 comments Download
M src/debug/debug.js View 23 chunks +33 lines, -27 lines 0 comments Download
M src/debug/mirrors.js View 4 chunks +12 lines, -3 lines 0 comments Download
M src/harmony-array.js View 2 chunks +4 lines, -3 lines 0 comments Download
M src/harmony-atomics.js View 10 chunks +12 lines, -11 lines 0 comments Download
M src/harmony-object.js View 1 chunk +0 lines, -1 line 0 comments Download
M src/harmony-regexp.js View 2 chunks +9 lines, -1 line 0 comments Download
M src/harmony-typedarray.js View 2 chunks +2 lines, -0 lines 0 comments Download
M src/i18n.js View 1 4 chunks +13 lines, -10 lines 0 comments Download
M src/json.js View 4 chunks +9 lines, -6 lines 0 comments Download
M src/macros.py View 1 chunk +3 lines, -3 lines 0 comments Download
M src/messages.js View 1 4 chunks +27 lines, -22 lines 0 comments Download
M src/prologue.js View 1 10 chunks +38 lines, -28 lines 0 comments Download
M src/regexp.js View 1 chunk +4 lines, -0 lines 0 comments Download
M src/runtime.js View 3 chunks +10 lines, -6 lines 0 comments Download
M src/string.js View 8 chunks +14 lines, -11 lines 0 comments Download
M src/symbol.js View 2 chunks +3 lines, -2 lines 0 comments Download
M src/typedarray.js View 1 chunk +2 lines, -0 lines 0 comments Download
M src/uri.js View 5 chunks +11 lines, -6 lines 0 comments Download
M src/v8natives.js View 1 13 chunks +24 lines, -21 lines 0 comments Download

Messages

Total messages: 7 (2 generated)
Yang
5 years, 4 months ago (2015-08-18 14:02:53 UTC) #1
Camillo Bruni
lgtm
5 years, 4 months ago (2015-08-19 06:20:41 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302533002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302533002/20001
5 years, 4 months ago (2015-08-19 07:20:45 UTC) #5
commit-bot: I haz the power
Committed patchset #2 (id:20001)
5 years, 4 months ago (2015-08-19 08:34:28 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 08:34:44 UTC) #7
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/eb8c092822c7745b49d3d97ec93edc2b0af72827
Cr-Commit-Position: refs/heads/master@{#30244}

Powered by Google App Engine
This is Rietveld 408576698