Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(180)

Unified Diff: src/debug/mirrors.js

Issue 1302533002: Native context: debug.js does not load from js builtins object anymore. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: make importing requirement more explicit Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/debug/debug.js ('k') | src/harmony-array.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/debug/mirrors.js
diff --git a/src/debug/mirrors.js b/src/debug/mirrors.js
index 85ff2b2a90e3cae5eb10ee852cd8ef6f870f451f..f47a2d058eaca4cdaacfdc1c7c8aa2a96a0b2aac 100644
--- a/src/debug/mirrors.js
+++ b/src/debug/mirrors.js
@@ -8,10 +8,19 @@
// ----------------------------------------------------------------------------
// Imports
+var FunctionSourceString;
var GlobalArray = global.Array;
var IsNaN = global.isNaN;
var JSONStringify = global.JSON.stringify;
var MathMin = global.Math.min;
+var ToBoolean;
+var ToString;
+
+utils.Import(function(from) {
+ FunctionSourceString = from.FunctionSourceString;
+ ToBoolean = from.ToBoolean;
+ ToString = from.ToString;
+});
// ----------------------------------------------------------------------------
@@ -990,7 +999,7 @@ FunctionMirror.prototype.source = function() {
// Return source if function is resolved. Otherwise just fall through to
// return undefined.
if (this.resolved()) {
- return builtins.$functionSourceString(this.value_);
+ return FunctionSourceString(this.value_);
}
};
@@ -1168,7 +1177,7 @@ ArrayMirror.prototype.indexedPropertiesFromRange = function(opt_from_index,
if (from_index > to_index) return new GlobalArray();
var values = new GlobalArray(to_index - from_index + 1);
for (var i = from_index; i <= to_index; i++) {
- var details = %DebugGetPropertyDetails(this.value_, builtins.$toString(i));
+ var details = %DebugGetPropertyDetails(this.value_, ToString(i));
var value;
if (details) {
value = new PropertyMirror(this, i, details);
@@ -2068,7 +2077,7 @@ FrameMirror.prototype.evaluate = function(source, disable_break,
this.details_.frameId(),
this.details_.inlinedFrameIndex(),
source,
- $toBoolean(disable_break),
+ ToBoolean(disable_break),
opt_context_object));
};
« no previous file with comments | « src/debug/debug.js ('k') | src/harmony-array.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698