Issue 1302493002: Explicitly require rooted device in `mojo_test`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1302493002: Explicitly require rooted device in `mojo_test`. (Closed)

Created:
5 years, 4 months ago by ppi

Modified:
5 years, 4 months ago

Reviewers:
etiennej

CC:
mojo-reviews_chromium.org, gregsimon, qsr+mojo_chromium.org, viettrungluu+watch_chromium.org, yzshen+watch_chromium.org, abarth-chromium, Aaron Boodman, darin (slow to review), ben+mojo_chromium.org

Base URL:
git@github.com:domokit/mojo.git@master

Target Ref:
refs/heads/master

Project:
mojo

Visibility:
Public.

More Reviews

Description

Explicitly require rooted device in `mojo_test`. We need root to get the stdout produced by the shell. Fixes #385. R=etiennej@chromium.org Committed: https://chromium.googlesource.com/external/mojo/+/2a14271a627481156afc8aa66da05da828f5d4d1

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+10 lines, -2 lines)			Patch
M	mojo/devtools/common/devtoolslib/android_shell.py	View	2 chunks	+4 lines, -1 line	0 comments	Download
M	mojo/devtools/common/devtoolslib/shell_arguments.py	View	1 chunk	+2 lines, -1 line	0 comments	Download
M	mojo/devtools/common/devtoolslib/shell_config.py	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	mojo/devtools/common/mojo_test	View	1 chunk	+3 lines, -0 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

ppi

5 years, 4 months ago (2015-08-19 08:35:29 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
2a14271a627481156afc8aa66da05da828f5d4d1 (presubmit successful).

Expand Messages | Collapse Messages