mojo/devtools/common/devtoolslib/shell_arguments.py - Issue 1302493002: Explicitly require rooted device in `mojo_test`.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/devtools/common/devtoolslib/shell_arguments.py

Issue 1302493002: Explicitly require rooted device in `mojo_test`. (Closed) Base URL: git@github.com:domokit/mojo.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: mojo/devtools/common/devtoolslib/shell_arguments.py

diff --git a/mojo/devtools/common/devtoolslib/shell_arguments.py b/mojo/devtools/common/devtoolslib/shell_arguments.py

index 20f512e0d18957d25509a1f23dc4bb192f5bc42f..f4792486bcd8a29288a1e55bc2d8318fe4c14b47 100644

--- a/mojo/devtools/common/devtoolslib/shell_arguments.py

+++ b/mojo/devtools/common/devtoolslib/shell_arguments.py

@@ -190,7 +190,8 @@ def get_shell(shell_config, shell_args):

logcat_tags=shell_config.logcat_tags,

verbose_pipe=verbose_pipe)

- device_status, error = shell.check_device()

+ device_status, error = shell.check_device(

+ require_root=shell_config.require_root)

if not device_status:

raise ShellConfigurationException('Device check failed: ' + error)

if shell_config.shell_path: