Issue 1302423008: Merge to XFA: Beef up app_props.in and tidy app.cpp.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1302423008: Merge to XFA: Beef up app_props.in and tidy app.cpp. (Closed)

Created:
5 years, 3 months ago by Tom Sepez

Modified:
5 years, 3 months ago

Reviewers:
Lei Zhang

CC:
pdfium-reviews_googlegroups.com

Base URL:
https://pdfium.googlesource.com/pdfium.git@xfa

Target Ref:
refs/heads/xfa

Visibility:
Public.

Merge to XFA: Beef up app_props.in and tidy app.cpp. Small manual edit in fpdfsdk/src/javascript/app.cpp (cherry picked from commit b830fbc03a6d12d8b5be50e85499c281a4c5da7f) Original Review URL: https://codereview.chromium.org/1317393003 . R=thestig@chromium.org TBR=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/d6278baea3dec46fec555f7740bde9087e57d8f1

Created: 5 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+127 lines, -21 lines)			Patch
M	fpdfsdk/src/javascript/app.cpp	View	4 chunks	+6 lines, -17 lines	0 comments	Download
M	testing/resources/javascript/app_props.in	View	3 chunks	+82 lines, -3 lines	0 comments	Download
M	testing/resources/javascript/app_props_expected.txt	View	1 chunk	+39 lines, -1 line	0 comments	Download

Total messages: 3 (0 generated)

Tom Sepez

5 years, 3 months ago (2015-09-08 23:34:40 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
d6278baea3dec46fec555f7740bde9087e57d8f1 (presubmit successful).