Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(531)

Issue 1317393003: Beef up app_props.in and tidy app.cpp (Closed)

Created:
5 years, 3 months ago by Tom Sepez
Modified:
5 years, 3 months ago
Reviewers:
Lei Zhang
CC:
pdfium-reviews_googlegroups.com
Base URL:
https://pdfium.googlesource.com/pdfium.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Beef up app_props.in and tidy app.cpp. Some of the values returned are dubious; capture the current state of affairs. R=thestig@chromium.org Committed: https://pdfium.googlesource.com/pdfium/+/b830fbc03a6d12d8b5be50e85499c281a4c5da7f

Patch Set 1 #

Patch Set 2 : Tidy app.cpp #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+125 lines, -19 lines) Patch
M fpdfsdk/src/javascript/app.cpp View 1 4 chunks +4 lines, -15 lines 1 comment Download
M testing/resources/javascript/app_props.in View 3 chunks +82 lines, -3 lines 0 comments Download
M testing/resources/javascript/app_props_expected.txt View 1 chunk +39 lines, -1 line 1 comment Download

Messages

Total messages: 5 (1 generated)
Tom Sepez
Lei, for review.
5 years, 3 months ago (2015-09-08 22:35:07 UTC) #2
Tom Sepez
On 2015/09/08 22:35:07, Tom Sepez wrote: > Lei, for review. And since no good CL ...
5 years, 3 months ago (2015-09-08 23:00:10 UTC) #3
Lei Zhang
lgtm https://codereview.chromium.org/1317393003/diff/20001/fpdfsdk/src/javascript/app.cpp File fpdfsdk/src/javascript/app.cpp (left): https://codereview.chromium.org/1317393003/diff/20001/fpdfsdk/src/javascript/app.cpp#oldcode56 fpdfsdk/src/javascript/app.cpp:56: #define JS_STR_VIEWERTYPE_READER L"Reader" Ah, these are the standard ...
5 years, 3 months ago (2015-09-08 23:21:36 UTC) #4
Tom Sepez
5 years, 3 months ago (2015-09-08 23:23:43 UTC) #5
Message was sent while issue was closed.
Committed patchset #2 (id:20001) manually as
b830fbc03a6d12d8b5be50e85499c281a4c5da7f (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698