Chromium Code Reviews Chromium Code Reviews
Issue 1302423006:
Ensure that data is not overwritten in the audio input shared memory ring buffer that sits on the b… (Closed)
Base URL: https://chromium.googlesource.com/chromium/src.git@master| Index: tools/metrics/histograms/histograms.xml |
| diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml |
| index 27455195e5988d3c44c62bad96bcef30c0a5c9a7..2e92bfa77c54e5f1a960e3a5e241ba0351aecba5 100644 |
| --- a/tools/metrics/histograms/histograms.xml |
| +++ b/tools/metrics/histograms/histograms.xml |
| @@ -16495,6 +16495,16 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <summary>Bits per channel of HTML5 audio sample data.</summary> |
| </histogram> |
| +<histogram name="Media.AudioCapturerMissedReadDeadline"> |
| + <owner>grunell@chromium.org</owner> |
| + <summary> |
| + The number of input audio read verifications that missed deadline. The read |
|
henrika (OOO until Aug 14)
2015/08/28 07:56:25
"missed deadline". Can it be rewritten? "Missed a
Henrik Grunell
2015/08/28 12:21:57
Tried to clarify this.
|
| + verification ensures that data is not overwritten in the shared ring buffer |
| + on the browser/renderer boundary before read by the other side. Reported at |
| + the destruction of low-latency audio input stream. |
| + </summary> |
| +</histogram> |
| + |
| <histogram name="Media.AudioChannelLayout" enum="ChannelLayout"> |
| <owner>dalecurtis@chromium.org</owner> |
| <summary>Audio channel layout in HTML5 media.</summary> |
| @@ -16600,6 +16610,7 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries. |
| <histogram name="Media.AudioTrackProcessingStates" |
| enum="AudioTrackProcessingStates"> |
| + <owner>grunell@chromium.org</owner> |
| <summary> |
| State of the media stream audio track processing, sampled once during the |
| life time of a MediaStreamAudioProcessor. |
