Get rid of redundant member function PositionAlgorithm<Strategy>::{upstream,downstream}

Get rid of redundant member function PositionAlgorithm<Strategy>::{upstream,downstream}

This patch gets rid of |PositionAlgorithm<Strategy>::{upstream,downstream}| by
replacing them by |most{Forward,Backward}CaretPosition()| to simplify
|PositionAlgorithm<Strategy>| template class for improving code health, since
|PositionAlgorithm<Strategy>::{upstream,downstream}| are simple wrapper
functions.

BUG=518738
TEST=n/a; no behavior changes

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201016

[yosin_UTC9, 2015-08-21 11:13:43]

yosin@chromium.org changed reviewers:
+ keishi@chromium.org

[yosin_UTC9, 2015-08-21 11:23:45]

PTAL

[keishi, 2015-08-21 12:04:20]

LGTM

[yosin, 2015-08-21 12:10:32]

The CQ bit was checked by yosin@google.com

[commit-bot: I haz the power, 2015-08-21 12:10:39]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302353002/1
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302353002/1

[commit-bot: I haz the power, 2015-08-21 12:15:37]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 12:15:38]

Try jobs failed on following builders:
  chromium_presubmit on tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[yosin_UTC9, 2015-08-21 15:02:59]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-21 15:02:59]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1302353002/#ps20001
(title: "2015-08-22T00:02:10")

[commit-bot: I haz the power, 2015-08-21 15:03:12]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302353002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302353002/20001

[commit-bot: I haz the power, 2015-08-21 19:27:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2015-08-21 19:27:10]

Failed to apply patch for Source/core/editing/PositionTest.cpp:
While running patch -p1 --forward --force --no-backup-if-mismatch;
  patching file Source/core/editing/PositionTest.cpp
  Hunk #1 FAILED at 12.
  Hunk #2 succeeded at 161 (offset 1 line).
  1 out of 2 hunks FAILED -- saving rejects to file
Source/core/editing/PositionTest.cpp.rej

Patch:       Source/core/editing/PositionTest.cpp
Index: Source/core/editing/PositionTest.cpp
diff --git a/Source/core/editing/PositionTest.cpp
b/Source/core/editing/PositionTest.cpp
index
35c24027fea69dc6745555bc2270c86827f45217..db8c33a9862ceee5b765e3019e95d2dc44838f7f
100644
--- a/Source/core/editing/PositionTest.cpp
+++ b/Source/core/editing/PositionTest.cpp
@@ -12,20 +12,6 @@ namespace blink {
 class PositionTest : public EditingTestBase {
 };
 
-TEST_F(PositionTest, downstreamAfterAnchor)
-{
-    const char* bodyContent = "<p id='host'><b id='one'>1</b></p><b
id='two'>22</b>";
-    const char* shadowContent = "<b id='two'>22</b><content
select=#one></content><b id='three'>333</b>";
-    setBodyContent(bodyContent);
-    setShadowContent(shadowContent);
-    updateLayoutAndStyleForPainting();
-
-    RefPtrWillBeRawPtr<Element> host = document().getElementById("host");
-
-    EXPECT_EQ(Position::lastPositionInNode(host.get()),
Position::afterNode(host.get()).downstream());
-    EXPECT_EQ(PositionInComposedTree::lastPositionInNode(host.get()),
PositionInComposedTree::afterNode(host.get()).downstream());
-}
-
 TEST_F(PositionTest, NextNodeIndex)
 {
     const char* bodyContent = "<p id='host'>00<b id='one'>11</b><b
id='two'>22</b>33</p>";
@@ -160,20 +146,4 @@ TEST_F(PositionTest,
ToPositionInComposedTreeWithEmptyShadowRoot)
     EXPECT_EQ(PositionInComposedTree(host, PositionAnchorType::AfterChildren),
toPositionInComposedTree(Position(shadowRoot.get(), 0)));
 }
 
-TEST_F(PositionTest, upstreamAfterAnchor)
-{
-    const char* bodyContent = "<p id='host'><b id='one'>1</b></p>";
-    const char* shadowContent = "<b id='two'>22</b><content
select=#one></content><b id='three'>333</b>";
-    setBodyContent(bodyContent);
-    RefPtrWillBeRawPtr<ShadowRoot> shadowRoot =
setShadowContent(shadowContent);
-    updateLayoutAndStyleForPainting();
-
-    RefPtrWillBeRawPtr<Element> host = document().getElementById("host");
-    RefPtrWillBeRawPtr<Element> one = document().getElementById("one");
-    RefPtrWillBeRawPtr<Element> three = shadowRoot->getElementById("three");
-
-    EXPECT_EQ(Position(one->firstChild(), 1),
Position::afterNode(host.get()).upstream());
-    EXPECT_EQ(PositionInComposedTree(three->firstChild(), 3),
PositionInComposedTree::afterNode(host.get()).upstream());
-}
-
 } // namespace blink

[commit-bot: I haz the power, 2015-08-21 19:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[yosin_UTC9, 2015-08-21 19:48:16]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-21 19:48:16]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1302353002/#ps40001
(title: "2015-08-22T04:47:27 Rebase")

[commit-bot: I haz the power, 2015-08-21 19:48:35]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302353002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302353002/40001

[yosin_UTC9, 2015-08-21 19:51:31]

The CQ bit was unchecked by yosin@chromium.org

[yosin_UTC9, 2015-08-21 19:52:02]

Patchset #3 (id:40001) has been deleted

[yosin_UTC9, 2015-08-21 19:52:16]

The CQ bit was checked by yosin@chromium.org

[yosin_UTC9, 2015-08-21 19:52:17]

The patchset sent to the CQ was uploaded after l-g-t-m from keishi@chromium.org
Link to the patchset: https://codereview.chromium.org/1302353002/#ps60001
(title: "2015-08-22T04:51:20 Rebase")

[commit-bot: I haz the power, 2015-08-21 19:52:32]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1302353002/60001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1302353002/60001

[commit-bot: I haz the power, 2015-08-21 21:24:59]

Committed patchset #3 (id:60001) as
https://src.chromium.org/viewvc/blink?view=rev&revision=201016