Source/core/editing/commands/InsertListCommand.cpp - Issue 1302353002: Get rid of redundant member function PositionAlgorithm<Strategy>::{upstream,downstream}

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/commands/InsertListCommand.cpp

Issue 1302353002: Get rid of redundant member function PositionAlgorithm<Strategy>::{upstream,downstream} (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: 2015-08-22T04:51:20 Rebase Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « Source/core/editing/commands/DeleteSelectionCommand.cpp ('k') | Source/core/editing/commands/InsertParagraphSeparatorCommand.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: Source/core/editing/commands/InsertListCommand.cpp

diff --git a/Source/core/editing/commands/InsertListCommand.cpp b/Source/core/editing/commands/InsertListCommand.cpp

index 50ae87704242539c32db1ebc6a453e5b6ce7e9c7..6bdfebbca519c3107222fe8ca78fdea1abf3a7d3 100644

--- a/Source/core/editing/commands/InsertListCommand.cpp

+++ b/Source/core/editing/commands/InsertListCommand.cpp

@@ -395,7 +395,7 @@ PassRefPtrWillBeRawPtr<HTMLElement> InsertListCommand::listifyParagraph(const Vi

// Try to avoid inserting it somewhere where it will be surrounded by

// inline ancestors of start, since it is easier for editing to produce

// clean markup when inline elements are pushed down as far as possible.

- Position insertionPos(start.deepEquivalent().upstream());

+ Position insertionPos(mostBackwardCaretPosition(start.deepEquivalent()));

// Also avoid the containing list item.

Node* listChild = enclosingListChild(insertionPos.anchorNode());

if (isHTMLLIElement(listChild))