Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8596)

Unified Diff: chrome/installer/util/master_preferences.cc

Issue 1302303002: Remove year+ old migration support of "session.urls_to_restore_on_startup". (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@pref_service_syncable_unittest
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/installer/util/master_preferences.cc
diff --git a/chrome/installer/util/master_preferences.cc b/chrome/installer/util/master_preferences.cc
index b021e8f55f2c5b88729e623bafafdcff094b163e..8b809daddab4ba77642f686cfc1d27427dbcd96c 100644
--- a/chrome/installer/util/master_preferences.cc
+++ b/chrome/installer/util/master_preferences.cc
@@ -251,19 +251,6 @@ void MasterPreferences::EnforceLegacyPreferences() {
distribution_->SetBoolean(
installer::master_preferences::kDoNotCreateQuickLaunchShortcut, true);
}
-
- // If there is no entry for kURLsToRestoreOnStartup and there is one for
- // kURLsToRestoreOnStartupOld, copy the old to the new.
- const base::ListValue* startup_urls_list = NULL;
- if (master_dictionary_ &&
- !master_dictionary_->GetList(prefs::kURLsToRestoreOnStartup, NULL) &&
- master_dictionary_->GetList(prefs::kURLsToRestoreOnStartupOld,
- &startup_urls_list) &&
- startup_urls_list) {
- base::ListValue* new_startup_urls_list = startup_urls_list->DeepCopy();
- master_dictionary_->Set(prefs::kURLsToRestoreOnStartup,
gab 2015/08/24 21:48:45 This is problematic because the "latest" master_pr
sdefresne 2015/08/25 08:36:10 +atwilson: WDYT? Can we remove this? Should I upda
sdefresne 2015/08/26 16:00:56 According to offline discussion, we can remove thi
- new_startup_urls_list);
- }
}
bool MasterPreferences::GetBool(const std::string& name, bool* value) const {

Powered by Google App Engine
This is Rietveld 408576698