Remove year+ old migration support of "session.urls_to_restore_on_startup".

chrome/installer/util/master_preferences.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/util/master_preferences.h"
 
 #include "base/environment.h"
 #include "base/files/file_util.h"
 #include "base/json/json_string_value_serializer.h"
 #include "base/lazy_instance.h"
@@ skipping 233 matching lines @@
   // do_not_create_(desktop|quick_launch)_shortcut to true.
   bool create_all_shortcuts = true;
   GetBool(installer::master_preferences::kCreateAllShortcuts,
           &create_all_shortcuts);
   if (!create_all_shortcuts) {
     distribution_->SetBoolean(
         installer::master_preferences::kDoNotCreateDesktopShortcut, true);
     distribution_->SetBoolean(
         installer::master_preferences::kDoNotCreateQuickLaunchShortcut, true);
   }
-
-  // If there is no entry for kURLsToRestoreOnStartup and there is one for
-  // kURLsToRestoreOnStartupOld, copy the old to the new.
-  const base::ListValue* startup_urls_list = NULL;
-  if (master_dictionary_ &&
-      !master_dictionary_->GetList(prefs::kURLsToRestoreOnStartup, NULL) &&
-      master_dictionary_->GetList(prefs::kURLsToRestoreOnStartupOld,
-                                  &startup_urls_list) &&
-      startup_urls_list) {
-    base::ListValue* new_startup_urls_list = startup_urls_list->DeepCopy();
-    master_dictionary_->Set(prefs::kURLsToRestoreOnStartup,

[gab, 2015/08/24 21:48:45]

This is problematic because the "latest" master_preferences documentation still
references the old value :-( :
https://www.chromium.org/administrators/configuring-other-preferences

Please loop in enterprise folks to see what to do about this.

[sdefresne, 2015/08/25 08:36:10]

+atwilson: WDYT? Can we remove this? Should I update the documentation?

[sdefresne, 2015/08/26 16:00:56]

According to offline discussion, we can remove this and the documentation has
been updated.

-                            new_startup_urls_list);
-  }
 }
 
 bool MasterPreferences::GetBool(const std::string& name, bool* value) const {
   bool ret = false;
   if (distribution_)
     ret = distribution_->GetBoolean(name, value);
   return ret;
 }
 
 bool MasterPreferences::GetInt(const std::string& name, int* value) const {
@@ skipping 43 matching lines @@
   }
   return result;
 }
 
 // static
 const MasterPreferences& MasterPreferences::ForCurrentProcess() {
   return g_master_preferences.Get();
 }
 
 }  // namespace installer