Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(35)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1302233010: Oilpan: Follow-up fix after r201698 (Closed)

Created:
5 years, 3 months ago by haraken
Modified:
5 years, 3 months ago
Reviewers:
oilpan-reviews, sof
CC:
blink-reviews, shans, blink-reviews-animation_chromium.org, Eric Willigers, rjwright, darktears
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: Follow-up fix after r201698 r201698 forgot to change one RefPtrWillBeRawPtr<AnimatableColor> to RefPtr<AnimatableColor>. This caused a couple of crashes in oilpan builds. http://build.chromium.org/p/chromium.webkit/builders/WebKit%20Linux%20Oilpan%20%28dbg%29/builds/3869 BUG= TBR=sigbjornf@opera.com Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=201717

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M Source/core/animation/animatable/AnimatableSVGPaint.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (1 generated)
haraken
This error should have been caught at compile time... I wonder why an implicit conversion ...
5 years, 3 months ago (2015-09-03 11:13:06 UTC) #2
haraken
Committed patchset #1 (id:1) manually as 201717 (presubmit successful).
5 years, 3 months ago (2015-09-03 11:13:55 UTC) #3
sof
On 2015/09/03 11:13:06, haraken wrote: > This error should have been caught at compile time... ...
5 years, 3 months ago (2015-09-03 11:19:01 UTC) #4
sof
5 years, 3 months ago (2015-09-03 11:19:12 UTC) #5
Message was sent while issue was closed. 
lgtm

Powered by Google App Engine
This is Rietveld 408576698