Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(53)

Issue 1302233007: Revert of heap: make array buffer maps disjoint (Closed)

Created:
5 years, 3 months ago by Michael Lippautz
Modified:
5 years, 3 months ago
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Revert of heap: make array buffer maps disjoint (patchset #8 id:140001 of https://codereview.chromium.org/1316873004/ ) Reason for revert: Precautionary revert. The change is incomplete. Original issue's description: > heap: make array buffer maps disjoint > > Remove intersection from the `std::map`s representing current live > ArrayBuffers. While being simpler to understand, it poses significant > performance issue for the active ArrayBuffer users (like node.js). > > Store buffers separately, and process them together during mark-sweep phase. > > The results of benchmarks are: > > $ ./node-slow bench && ./node-fast bench > 4997.4 ns/op > 4685.7 ns/op > > NOTE: `fast` - was a patched node.js, `slow` - unpatched node.js with vanilla v8. > > BUG= > > Committed: https://crrev.com/9e3676da9ab1aaf7de3e8582cb3fdefcc3dbaf33 > Cr-Commit-Position: refs/heads/master@{#30495} TBR=hpayer@chromium.org,fedor@indutny.com NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG= Committed: https://crrev.com/bb7b53110e3478a38b4d2429aaab6576359deda1 Cr-Commit-Position: refs/heads/master@{#30502}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+103 lines, -64 lines) Patch
M src/heap/heap.h View 1 chunk +15 lines, -0 lines 0 comments Download
M src/heap/heap.cc View 3 chunks +86 lines, -59 lines 0 comments Download
M src/heap/mark-compact.cc View 1 chunk +2 lines, -5 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Lippautz
Created Revert of heap: make array buffer maps disjoint
5 years, 3 months ago (2015-09-01 09:58:08 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1302233007/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1302233007/1
5 years, 3 months ago (2015-09-01 09:58:19 UTC) #2
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 3 months ago (2015-09-01 09:58:32 UTC) #3
commit-bot: I haz the power
5 years, 3 months ago (2015-09-01 09:58:51 UTC) #4
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/bb7b53110e3478a38b4d2429aaab6576359deda1
Cr-Commit-Position: refs/heads/master@{#30502}

Powered by Google App Engine
This is Rietveld 408576698