Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(231)

Unified Diff: src/heap/mark-compact.cc

Issue 1302233007: Revert of heap: make array buffer maps disjoint (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/heap/heap.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/heap/mark-compact.cc
diff --git a/src/heap/mark-compact.cc b/src/heap/mark-compact.cc
index d431aa0dfa082eb791fb87d037e8865edb1f1155..f95b91ac4db80791a7cf2dc9ea408e9369a1286e 100644
--- a/src/heap/mark-compact.cc
+++ b/src/heap/mark-compact.cc
@@ -4431,12 +4431,9 @@
// buffer entries are already filter out. We can just release the memory.
heap()->FreeQueuedChunks();
+ heap()->FreeDeadArrayBuffers(false);
+
EvacuateNewSpaceAndCandidates();
-
- // NOTE: ArrayBuffers must be evacuated first, before freeing them. Otherwise
- // not yet discovered buffers for scavenge will have all of them, and they
- // will be erroneously freed.
- heap()->FreeDeadArrayBuffers(false);
// Clear the marking state of live large objects.
heap_->lo_space()->ClearMarkingStateOfLiveObjects();
« no previous file with comments | « src/heap/heap.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698