Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(36)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 130213009: Various extension-related cleanup and simplifications. (Closed)

Created:
6 years, 11 months ago by Sven Panne
Modified:
6 years, 11 months ago
Reviewers:
dcarney
CC:
v8-dev, Paweł Hajdan Jr.
Visibility:
Public.

Description

Various extension-related cleanup and simplifications. Removes the embarrassing "static"s, shuffles some code around, doing various cleanups on the way. R=dcarney@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=18659

Patch Set 1 #

Patch Set 2 : Less statics #

Patch Set 3 : New files #

Patch Set 4 : Removed dead code #

Patch Set 5 : Removed statics. #

Patch Set 6 : Whitespace #

Unified diffs Side-by-side diffs Delta from patch set Stats (+316 lines, -392 lines) Patch
M include/v8.h View 1 chunk +0 lines, -11 lines 0 comments Download
M src/bootstrapper.h View 1 2 3 4 2 chunks +7 lines, -0 lines 0 comments Download
M src/bootstrapper.cc View 1 2 3 4 5 1 chunk +32 lines, -5 lines 0 comments Download
M src/extensions/externalize-string-extension.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/externalize-string-extension.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M src/extensions/free-buffer-extension.h View 1 2 3 4 1 chunk +2 lines, -3 lines 0 comments Download
M src/extensions/free-buffer-extension.cc View 1 2 3 4 1 chunk +0 lines, -10 lines 0 comments Download
M src/extensions/gc-extension.h View 1 2 3 4 1 chunk +11 lines, -2 lines 0 comments Download
M src/extensions/gc-extension.cc View 1 2 3 4 1 chunk +0 lines, -14 lines 0 comments Download
M src/extensions/statistics-extension.h View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M src/extensions/statistics-extension.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M src/extensions/trigger-failure-extension.h View 1 2 3 4 1 chunk +0 lines, -1 line 0 comments Download
M src/extensions/trigger-failure-extension.cc View 1 2 3 4 1 chunk +0 lines, -6 lines 0 comments Download
M src/v8.cc View 1 2 3 4 1 chunk +1 line, -0 lines 0 comments Download
M test/cctest/cctest.h View 1 chunk +5 lines, -4 lines 0 comments Download
M test/cctest/cctest.cc View 1 2 chunks +11 lines, -0 lines 0 comments Download
M test/cctest/cctest.gyp View 1 2 chunks +3 lines, -1 line 0 comments Download
A + test/cctest/print-extension.h View 1 2 3 2 chunks +7 lines, -8 lines 0 comments Download
A + test/cctest/print-extension.cc View 1 2 2 chunks +14 lines, -19 lines 0 comments Download
M test/cctest/profiler-extension.h View 1 2 chunks +11 lines, -0 lines 0 comments Download
M test/cctest/profiler-extension.cc View 1 2 chunks +5 lines, -4 lines 0 comments Download
M test/cctest/test-compiler.cc View 1 1 chunk +0 lines, -44 lines 0 comments Download
M test/cctest/test-cpu-profiler.cc View 1 16 chunks +26 lines, -31 lines 0 comments Download
M test/cctest/test-heap-profiler.cc View 1 1 chunk +0 lines, -51 lines 0 comments Download
M test/cctest/test-log-stack-tracer.cc View 1 9 chunks +11 lines, -138 lines 0 comments Download
M test/cctest/test-profile-generator.cc View 1 5 chunks +11 lines, -16 lines 0 comments Download
A + test/cctest/trace-extension.h View 1 2 2 chunks +15 lines, -10 lines 0 comments Download
A test/cctest/trace-extension.cc View 1 2 1 chunk +142 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Sven Panne
6 years, 11 months ago (2014-01-17 10:41:04 UTC) #1
dcarney
lgtm
6 years, 11 months ago (2014-01-17 10:47:30 UTC) #2
Sven Panne
6 years, 11 months ago (2014-01-17 10:52:23 UTC) #3
Message was sent while issue was closed. 
Committed patchset #6 manually as r18659 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698