Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(350)

Side by Side Diff: src/extensions/externalize-string-extension.cc

Issue 130213009: Various extension-related cleanup and simplifications. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge
Patch Set: Whitespace Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « src/extensions/externalize-string-extension.h ('k') | src/extensions/free-buffer-extension.h » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2010 the V8 project authors. All rights reserved. 1 // Copyright 2010 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 127 matching lines...) Expand 10 before | Expand all | Expand 10 after
138 args.GetIsolate()->ThrowException(v8::String::NewFromUtf8( 138 args.GetIsolate()->ThrowException(v8::String::NewFromUtf8(
139 args.GetIsolate(), 139 args.GetIsolate(),
140 "isAsciiString() requires a single string argument.")); 140 "isAsciiString() requires a single string argument."));
141 return; 141 return;
142 } 142 }
143 bool is_one_byte = 143 bool is_one_byte =
144 Utils::OpenHandle(*args[0].As<v8::String>())->IsOneByteRepresentation(); 144 Utils::OpenHandle(*args[0].As<v8::String>())->IsOneByteRepresentation();
145 args.GetReturnValue().Set(is_one_byte); 145 args.GetReturnValue().Set(is_one_byte);
146 } 146 }
147 147
148
149 void ExternalizeStringExtension::Register() {
150 static ExternalizeStringExtension externalize_extension;
151 static v8::DeclareExtension declaration(&externalize_extension);
152 }
153
154 } } // namespace v8::internal 148 } } // namespace v8::internal
OLDNEW
« no previous file with comments | « src/extensions/externalize-string-extension.h ('k') | src/extensions/free-buffer-extension.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698