runtime/vm/instructions_mips.cc - Issue 1301963003: VM: Clean up and fix bugs in instructions patterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/instructions_mips.cc

Issue 1301963003: VM: Clean up and fix bugs in instructions patterns (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: s/Pattern::InstructionLength/Pattern::pattern_length_in_bytes/g Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/instructions_mips.cc

diff --git a/runtime/vm/instructions_mips.cc b/runtime/vm/instructions_mips.cc

index 34a5c3a460970d7bb805e91314a6d6fd98c195cb..0d11873052775ad7d602a2e24b61fcb93d36ff79 100644

--- a/runtime/vm/instructions_mips.cc

+++ b/runtime/vm/instructions_mips.cc

@@ -118,9 +118,7 @@ uword InstructionPattern::DecodeLoadWordFromPool(uword end,

// Offset is signed, so add the upper 16 bits.

offset += (instr->UImmField() << 16);

}

- offset += kHeapObjectTag;

- ASSERT(Utils::IsAligned(offset, 4));

- *index = (offset - Array::data_offset()) / 4;

+ *index = ObjectPool::IndexFromOffset(offset);

return start;

}