runtime/vm/instructions_arm.cc - Issue 1301963003: VM: Clean up and fix bugs in instructions patterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/instructions_arm.cc

Issue 1301963003: VM: Clean up and fix bugs in instructions patterns (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: s/Pattern::InstructionLength/Pattern::pattern_length_in_bytes/g Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/instructions_arm.cc

diff --git a/runtime/vm/instructions_arm.cc b/runtime/vm/instructions_arm.cc

index 6709c19c93f070173a06e95088e23f42dd85ca1c..6f52b56d142dda0050582c2c03f3f896e6a28837 100644

--- a/runtime/vm/instructions_arm.cc

+++ b/runtime/vm/instructions_arm.cc

@@ -150,9 +150,7 @@ uword InstructionPattern::DecodeLoadWordFromPool(uword end,

end = DecodeLoadWordImmediate(end, reg, &offset);

}

- offset += kHeapObjectTag;

- ASSERT(Utils::IsAligned(offset, 4));

rmacnak 2015/08/20 20:44:54 Consider pushing the alignment assert into ObjectP

Florian Schneider 2015/08/21 07:45:09 Done (in my other CL).

- *index = (offset - Array::data_offset()) / 4;

+ *index = ObjectPool::IndexFromOffset(offset);

return start;

}

« no previous file with comments | « runtime/vm/code_patcher_x64.cc ('k') | runtime/vm/instructions_arm64.cc » ('j') | no next file with comments »