runtime/vm/instructions_arm64.cc - Issue 1301963003: VM: Clean up and fix bugs in instructions patterns

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/instructions_arm64.cc

Issue 1301963003: VM: Clean up and fix bugs in instructions patterns (Closed) Base URL: git@github.com:dart-lang/sdk.git@master

Patch Set: s/Pattern::InstructionLength/Pattern::pattern_length_in_bytes/g Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/instructions_arm64.cc

diff --git a/runtime/vm/instructions_arm64.cc b/runtime/vm/instructions_arm64.cc

index 1690456a34d0fa85ea26310ea37fee4a8e789226..9987527126276f79549da9d6573594c90c416d17 100644

--- a/runtime/vm/instructions_arm64.cc

+++ b/runtime/vm/instructions_arm64.cc

@@ -208,8 +208,9 @@ uword InstructionPattern::DecodeLoadWordFromPool(uword end,

offset |= instr->Imm16Field();

}

+ // PP is untagged on ARM64.

ASSERT(Utils::IsAligned(offset, 8));

- *index = (offset - Array::data_offset()) / 8;

+ *index = ObjectPool::IndexFromOffset(offset - kHeapObjectTag);

return start;

}