Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(800)

Unified Diff: runtime/vm/code_patcher_ia32.cc

Issue 1301963003: VM: Clean up and fix bugs in instructions patterns (Closed) Base URL: git@github.com:dart-lang/sdk.git@master
Patch Set: s/Pattern::InstructionLength/Pattern::pattern_length_in_bytes/g Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | runtime/vm/code_patcher_x64.cc » ('j') | runtime/vm/instructions_arm.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: runtime/vm/code_patcher_ia32.cc
diff --git a/runtime/vm/code_patcher_ia32.cc b/runtime/vm/code_patcher_ia32.cc
index 08d95b4c8499c4bcbd6672807290e3dd4a7d3a40..08c7caf03b2ac44ea8bf3d027643369ed5393084 100644
--- a/runtime/vm/code_patcher_ia32.cc
+++ b/runtime/vm/code_patcher_ia32.cc
@@ -178,11 +178,11 @@ void CodePatcher::PatchInstanceCallAt(uword return_address,
void CodePatcher::InsertCallAt(uword start, uword target) {
// The inserted call should not overlap the lazy deopt jump code.
- ASSERT(start + CallPattern::InstructionLength() <= target);
+ ASSERT(start + CallPattern::pattern_length_in_bytes() <= target);
*reinterpret_cast<uint8_t*>(start) = 0xE8;
CallPattern call(start);
call.SetTargetAddress(target);
- CPU::FlushICache(start, CallPattern::InstructionLength());
+ CPU::FlushICache(start, CallPattern::pattern_length_in_bytes());
}
« no previous file with comments | « no previous file | runtime/vm/code_patcher_x64.cc » ('j') | runtime/vm/instructions_arm.cc » ('J')

Powered by Google App Engine
This is Rietveld 408576698