Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1666)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: build/gyp_chromium

Issue 130183002: Fix handling of visual studio override when using automated toolchain. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: build/gyp_chromium
diff --git a/build/gyp_chromium b/build/gyp_chromium
index fd3354597785e4fe48fe347b73140f1ef5dff7fe..fe07911b5b5932543869922ac4acd55370611468 100755
--- a/build/gyp_chromium
+++ b/build/gyp_chromium
@@ -189,7 +189,7 @@ def GetArgsStringForGN(supplemental_files):
gn_args += ' visual_studio_version=' + EscapeStringForGN(gyp_msvs_version)
gyp_msvs_override_path = os.environ.get('GYP_MSVS_OVERRIDE_PATH', '')
if gyp_msvs_override_path:
- gn_args += ' visual_studio_override_path=' + \
+ gn_args += ' visual_studio_path=' + \
EscapeStringForGN(gyp_msvs_override_path)
# Set the GYP flag so BUILD files know they're being invoked in GYP mode.
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698