Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Side by Side Diff: build/gyp_chromium

Issue 130183002: Fix handling of visual studio override when using automated toolchain. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 11 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 #!/usr/bin/env python 1 #!/usr/bin/env python
2 2
3 # Copyright (c) 2012 The Chromium Authors. All rights reserved. 3 # Copyright (c) 2012 The Chromium Authors. All rights reserved.
4 # Use of this source code is governed by a BSD-style license that can be 4 # Use of this source code is governed by a BSD-style license that can be
5 # found in the LICENSE file. 5 # found in the LICENSE file.
6 6
7 # This script is wrapper for Chromium that adds some support for how GYP 7 # This script is wrapper for Chromium that adds some support for how GYP
8 # is invoked by Chromium beyond what can be done in the gclient hooks. 8 # is invoked by Chromium beyond what can be done in the gclient hooks.
9 9
10 import glob 10 import glob
(...skipping 171 matching lines...) Expand 10 before | Expand all | Expand 10 after
182 for v in ['arm_version']: 182 for v in ['arm_version']:
183 if v in vars_dict: 183 if v in vars_dict:
184 gn_args += ' %s=%s' % (v, vars_dict[v]) 184 gn_args += ' %s=%s' % (v, vars_dict[v])
185 185
186 # Some other flags come from GYP environment variables. 186 # Some other flags come from GYP environment variables.
187 gyp_msvs_version = os.environ.get('GYP_MSVS_VERSION', '') 187 gyp_msvs_version = os.environ.get('GYP_MSVS_VERSION', '')
188 if gyp_msvs_version: 188 if gyp_msvs_version:
189 gn_args += ' visual_studio_version=' + EscapeStringForGN(gyp_msvs_version) 189 gn_args += ' visual_studio_version=' + EscapeStringForGN(gyp_msvs_version)
190 gyp_msvs_override_path = os.environ.get('GYP_MSVS_OVERRIDE_PATH', '') 190 gyp_msvs_override_path = os.environ.get('GYP_MSVS_OVERRIDE_PATH', '')
191 if gyp_msvs_override_path: 191 if gyp_msvs_override_path:
192 gn_args += ' visual_studio_override_path=' + \ 192 gn_args += ' visual_studio_path=' + \
193 EscapeStringForGN(gyp_msvs_override_path) 193 EscapeStringForGN(gyp_msvs_override_path)
194 194
195 # Set the GYP flag so BUILD files know they're being invoked in GYP mode. 195 # Set the GYP flag so BUILD files know they're being invoked in GYP mode.
196 gn_args += ' is_gyp=true' 196 gn_args += ' is_gyp=true'
197 return gn_args.strip() 197 return gn_args.strip()
198 198
199 199
200 def additional_include_files(supplemental_files, args=[]): 200 def additional_include_files(supplemental_files, args=[]):
201 """ 201 """
202 Returns a list of additional (.gypi) files to include, without duplicating 202 Returns a list of additional (.gypi) files to include, without duplicating
(...skipping 170 matching lines...) Expand 10 before | Expand all | Expand 10 after
373 # to enfore syntax checking. 373 # to enfore syntax checking.
374 syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK') 374 syntax_check = os.environ.get('CHROMIUM_GYP_SYNTAX_CHECK')
375 if syntax_check and int(syntax_check): 375 if syntax_check and int(syntax_check):
376 args.append('--check') 376 args.append('--check')
377 377
378 print 'Updating projects from gyp files...' 378 print 'Updating projects from gyp files...'
379 sys.stdout.flush() 379 sys.stdout.flush()
380 380
381 # Off we go... 381 # Off we go...
382 sys.exit(gyp.main(args)) 382 sys.exit(gyp.main(args))
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698