Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(47)

Issue 130183002: Fix handling of visual studio override when using automated toolchain. (Closed)

Created:
6 years, 11 months ago by ncarter (slow)
Modified:
6 years, 11 months ago
Reviewers:
brettw, scottmg
CC:
chromium-reviews
Visibility:
Public.

Description

Fix handling of visual studio override when using automated toolchain. BUG= Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=243845

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M build/gyp_chromium View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 5 (0 generated)
ncarter (slow)
6 years, 11 months ago (2014-01-09 00:59:45 UTC) #1
scottmg
lgtm
6 years, 11 months ago (2014-01-09 01:00:52 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/nick@chromium.org/130183002/1
6 years, 11 months ago (2014-01-09 01:28:35 UTC) #3
brettw
Thanks for tracking that down, I changed the name and forgot to update the script.
6 years, 11 months ago (2014-01-09 05:24:42 UTC) #4
commit-bot: I haz the power
6 years, 11 months ago (2014-01-09 11:40:40 UTC) #5
Message was sent while issue was closed.
Change committed as 243845

Powered by Google App Engine
This is Rietveld 408576698