Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(43)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1301823002: Put drawPath in GrBatch. (Closed)

Created:
5 years, 4 months ago by bsalomon
Modified:
5 years, 4 months ago
Reviewers:
joshualitt
CC:
reviews_skia.org
Base URL:
https://skia.googlesource.com/skia.git@nvprbatch
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Put drawPath in GrBatch. TODO: Implement path range version of this (and preserve combining consecutive ranges). Committed: https://skia.googlesource.com/skia/+/add79ef7cb2ebd7b80bf0fd5e70281ec6ad5f079

Patch Set 1 #

Patch Set 2 : rebae #

Patch Set 3 : update #

Unified diffs Side-by-side diffs Delta from patch set Stats (+98 lines, -64 lines) Patch
M gyp/gpu.gypi View 1 1 chunk +1 line, -0 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrBufferedDrawTarget.cpp View 1 chunk +0 lines, -12 lines 0 comments Download
M src/gpu/GrCommandBuilder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrDrawTarget.cpp View 4 chunks +22 lines, -12 lines 0 comments Download
M src/gpu/GrImmediateDrawTarget.h View 1 chunk +0 lines, -6 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.h View 1 chunk +0 lines, -4 lines 0 comments Download
M src/gpu/GrInOrderCommandBuilder.cpp View 1 chunk +0 lines, -10 lines 0 comments Download
M src/gpu/GrReorderCommandBuilder.h View 1 chunk +0 lines, -8 lines 0 comments Download
A src/gpu/batches/GrDrawPathBatch.h View 1 2 1 chunk +75 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
bsalomon
5 years, 4 months ago (2015-08-19 20:12:19 UTC) #2
joshualitt
On 2015/08/19 20:12:19, bsalomon wrote: lgtm
5 years, 4 months ago (2015-08-19 20:15:07 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301823002/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301823002/40001
5 years, 4 months ago (2015-08-19 20:19:47 UTC) #5
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 20:26:53 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) as
https://skia.googlesource.com/skia/+/add79ef7cb2ebd7b80bf0fd5e70281ec6ad5f079

Powered by Google App Engine
This is Rietveld 408576698