Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(457)

Issue 1301743003: Sync more GN unit tests with GYP. (Closed)

Created:
5 years, 4 months ago by brettw
Modified:
5 years, 4 months ago
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, wjmaclean, zea+watch_chromium.org, pvalenzuela+watch_chromium.org, browser-components-watch_chromium.org, maxbogue+watch_chromium.org, jam, chromium-apps-reviews_chromium.org, plaree+watch_chromium.org, darin-cc_chromium.org, noyau+watch_chromium.org, asvitkine+watch_chromium.org, tfarina, estade+watch_chromium.org, rouslan+autofillwatch_chromium.org, Yuki, henrika (OOO until Aug 14), nasko
Base URL:
https://chromium.googlesource.com/chromium/src.git@tests3
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Sync more GN unit tests with GYP. This adds about 600 more tests. Tests added: invalidation, navigation interception, feedback, search, sync driver, enhanced bookmarks, search engines, sessions, data reduction proxy, favicon, constrained window, autofill, metrics, keyed service, bookmarks, suggestions, audio modem I renamed ui_zoom to "zoom" according to GN style. I tweaked some jingle public dependencies so the right include directories get forwarded along with the corresponding uses in the headers. BUG= R=dpranke@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/a7cde4bd39dc814952d885e54eee33ffdac1a881

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+287 lines, -74 lines) Patch
M chrome/browser/BUILD.gn View 1 1 chunk +1 line, -1 line 0 comments Download
M components/BUILD.gn View 7 chunks +17 lines, -3 lines 0 comments Download
M components/audio_modem/BUILD.gn View 4 chunks +24 lines, -4 lines 0 comments Download
M components/autofill/core/browser/BUILD.gn View 1 chunk +1 line, -0 lines 0 comments Download
M components/bookmarks/browser/BUILD.gn View 1 chunk +4 lines, -0 lines 0 comments Download
M components/components_tests.gyp View 1 1 chunk +0 lines, -1 line 0 comments Download
M components/constrained_window/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/data_reduction_proxy/core/browser/BUILD.gn View 2 chunks +2 lines, -1 line 0 comments Download
M components/enhanced_bookmarks/BUILD.gn View 1 chunk +15 lines, -1 line 0 comments Download
M components/favicon/content/BUILD.gn View 2 chunks +16 lines, -2 lines 0 comments Download
M components/favicon/core/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/feedback/BUILD.gn View 2 chunks +17 lines, -1 line 0 comments Download
M components/guest_view/browser/BUILD.gn View 2 chunks +3 lines, -2 lines 0 comments Download
M components/invalidation/impl/BUILD.gn View 4 chunks +32 lines, -6 lines 0 comments Download
M components/keyed_service/content/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M components/keyed_service/core/BUILD.gn View 1 chunk +11 lines, -0 lines 0 comments Download
M components/metrics/BUILD.gn View 2 chunks +5 lines, -0 lines 0 comments Download
M components/navigation_interception/BUILD.gn View 2 chunks +14 lines, -1 line 0 comments Download
M components/rappor/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/search/BUILD.gn View 2 chunks +13 lines, -1 line 0 comments Download
M components/search_engines/BUILD.gn View 1 chunk +20 lines, -1 line 0 comments Download
M components/sessions/BUILD.gn View 1 chunk +6 lines, -0 lines 0 comments Download
M components/suggestions/BUILD.gn View 3 chunks +23 lines, -6 lines 0 comments Download
M components/sync_driver/BUILD.gn View 1 2 4 chunks +36 lines, -35 lines 0 comments Download
M components/ui/zoom/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M components/ui_zoom.gypi View 1 chunk +1 line, -0 lines 0 comments Download
M components/web_modal/BUILD.gn View 2 chunks +4 lines, -1 line 0 comments Download
M extensions/browser/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download
M jingle/BUILD.gn View 1 chunk +4 lines, -1 line 0 comments Download
M pdf/BUILD.gn View 1 chunk +1 line, -1 line 0 comments Download

Dependent Patchsets:

Messages

Total messages: 21 (10 generated)
brettw
5 years, 4 months ago (2015-08-19 22:38:10 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301743003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301743003/1
5 years, 4 months ago (2015-08-19 22:39:00 UTC) #4
Dirk Pranke
lgtm
5 years, 4 months ago (2015-08-19 22:46:12 UTC) #5
commit-bot: I haz the power
Dry run: Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/105751)
5 years, 4 months ago (2015-08-20 00:03:38 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301743003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301743003/20001
5 years, 4 months ago (2015-08-20 16:37:03 UTC) #10
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_gn_dbg on tryserver.chromium.linux (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_gn_dbg/builds/106110)
5 years, 4 months ago (2015-08-20 17:24:58 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301743003/40001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301743003/40001
5 years, 4 months ago (2015-08-20 18:13:21 UTC) #15
brettw
Committed patchset #3 (id:40001) manually as a7cde4bd39dc814952d885e54eee33ffdac1a881 (presubmit successful).
5 years, 4 months ago (2015-08-20 20:27:06 UTC) #16
Lei Zhang
This is breaking GN builds again. :-P
5 years, 4 months ago (2015-08-20 21:14:23 UTC) #18
msramek
This seems to have broken builds: Windows: http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN%20%28dbg%29/builds/7901 (the build stops at audio_recorder_unittest.cc, which was ...
5 years, 4 months ago (2015-08-21 13:21:55 UTC) #20
nasko
5 years, 4 months ago (2015-08-21 14:10:18 UTC) #21
Message was sent while issue was closed.
A revert of this CL (patchset #3 id:40001) has been created in
https://codereview.chromium.org/1306153002/ by nasko@chromium.org.

The reason for reverting is: This has broken the GN builds. Windows is failing
compilation and Mac is failing generate_build_files.

http://build.chromium.org/p/chromium.mac/builders/Mac%20GN/builds/15185/steps...
http://build.chromium.org/p/chromium.win/builders/Win%20x64%20GN/builds/5562/...
.

Powered by Google App Engine
This is Rietveld 408576698