Make heap.h usable without objects-inl.h header.

Make heap.h usable without objects-inl.h header.

This CL us a pure refactoring that makes an empty compilation unit
including just "heap.h" but not "objects-inl.h" compile without
warnings or errors. This is needed to further reduce the header
dependency tangle.

R=mlippautz@chromium.org

Committed: https://crrev.com/f2796382d7c1a27fec53c1f7dc445181ee701c98
Cr-Commit-Position: refs/heads/master@{#30227}

[Michael Starzinger, 2015-08-17 13:17:06]

https://codereview.chromium.org/1301583003/diff/1/src/heap/identity-map.cc
File src/heap/identity-map.cc (left):

https://codereview.chromium.org/1301583003/diff/1/src/heap/identity-map.cc#ol...
src/heap/identity-map.cc:8: #include "src/objects-inl.h"  // TODO(mstarzinger):
Temporary cycle breaker!
Yay! \o/

[Michael Lippautz, 2015-08-17 13:42:35]

https://codereview.chromium.org/1301583003/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1301583003/diff/1/src/heap/heap.cc#newcode2620
src/heap/heap.cc:2620: void Heap::DoScavengeObject(Map* map, HeapObject** slot,
HeapObject* obj) {
On purpose in heap.cc? Shouldn't we move it to heap-inl.h for uniformity?

(works because the only compilation unit using it is heap.cc)

[Michael Starzinger, 2015-08-17 14:22:55]

https://codereview.chromium.org/1301583003/diff/1/src/heap/heap.cc
File src/heap/heap.cc (right):

https://codereview.chromium.org/1301583003/diff/1/src/heap/heap.cc#newcode2620
src/heap/heap.cc:2620: void Heap::DoScavengeObject(Map* map, HeapObject** slot,
HeapObject* obj) {
On 2015/08/17 13:42:35, Michael Lippautz wrote:
> On purpose in heap.cc? Shouldn't we move it to heap-inl.h for uniformity?
> 
> (works because the only compilation unit using it is heap.cc)

Done. Yes, you are right. As discussed offline, moving it into heap-inl.h would
expose all of objects-visiting-inl.h again. In the long run this indirection
should disappear. For now we made it private, which is already a step forward.

[Michael Lippautz, 2015-08-17 14:28:29]

lgtm

[Michael Lippautz, 2015-08-18 16:13:26]

still lgtm

[Michael Starzinger, 2015-08-18 16:15:39]

The CQ bit was checked by mstarzinger@chromium.org

[commit-bot: I haz the power, 2015-08-18 16:15:45]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1301583003/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1301583003/40001

[commit-bot: I haz the power, 2015-08-18 16:21:38]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2015-08-18 16:21:46]

Patchset 3 (id:??) landed as
https://crrev.com/f2796382d7c1a27fec53c1f7dc445181ee701c98
Cr-Commit-Position: refs/heads/master@{#30227}