Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(582)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1291833003: Remove grab-bag includes of v8.h from heap. (Closed)

Created:
5 years, 4 months ago by Michael Starzinger
Modified:
5 years, 4 months ago
Reviewers:
Michael Lippautz
CC:
v8-dev
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Remove grab-bag includes of v8.h from heap. R=mlippautz@chromium.org Committed: https://crrev.com/1c567f82817f449e54e6fcd41940fe10fbddcea7 Cr-Commit-Position: refs/heads/master@{#30195}

Patch Set 1 #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -17 lines) Patch
M src/heap/gc-idle-time-handler.cc View 1 chunk +2 lines, -1 line 0 comments Download
M src/heap/gc-tracer.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/gc-tracer.cc View 1 chunk +5 lines, -2 lines 0 comments Download
M src/heap/heap.cc View 2 chunks +2 lines, -1 line 2 comments Download
M src/heap/identity-map.h View 1 chunk +2 lines, -0 lines 0 comments Download
M src/heap/identity-map.cc View 1 chunk +3 lines, -2 lines 0 comments Download
M src/heap/incremental-marking.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/incremental-marking.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M src/heap/mark-compact.cc View 3 chunks +2 lines, -2 lines 0 comments Download
M src/heap/mark-compact-inl.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/heap/objects-visiting.h View 1 chunk +1 line, -0 lines 0 comments Download
M src/heap/objects-visiting.cc View 1 chunk +1 line, -2 lines 0 comments Download
M src/heap/spaces.cc View 1 chunk +1 line, -1 line 0 comments Download
M src/heap/store-buffer.cc View 1 chunk +3 lines, -2 lines 2 comments Download
M src/heap/store-buffer-inl.h View 1 chunk +1 line, -0 lines 0 comments Download

Dependent Patchsets:

Issue 1301583003 Patch 1
Issue 1301583003 Patch 20001
Issue 1301583003 Patch 40001

Messages

Total messages: 7 (1 generated)
Michael Starzinger
5 years, 4 months ago (2015-08-17 12:23:42 UTC) #1
Michael Lippautz
lgtm https://codereview.chromium.org/1291833003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1291833003/diff/1/src/heap/heap.cc#newcode36 src/heap/heap.cc:36: #include "src/v8.h" :( https://codereview.chromium.org/1291833003/diff/1/src/heap/store-buffer.cc File src/heap/store-buffer.cc (right): https://codereview.chromium.org/1291833003/diff/1/src/heap/store-buffer.cc#newcode11 ...
5 years, 4 months ago (2015-08-17 12:41:51 UTC) #2
Michael Starzinger
https://codereview.chromium.org/1291833003/diff/1/src/heap/heap.cc File src/heap/heap.cc (right): https://codereview.chromium.org/1291833003/diff/1/src/heap/heap.cc#newcode36 src/heap/heap.cc:36: #include "src/v8.h" On 2015/08/17 12:41:51, Michael Lippautz wrote: > ...
5 years, 4 months ago (2015-08-17 12:46:46 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1291833003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1291833003/1
5 years, 4 months ago (2015-08-17 13:11:45 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
5 years, 4 months ago (2015-08-17 13:13:36 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-17 13:13:50 UTC) #7
Message was sent while issue was closed. 
Patchset 1 (id:??) landed as
https://crrev.com/1c567f82817f449e54e6fcd41940fe10fbddcea7
Cr-Commit-Position: refs/heads/master@{#30195}

Powered by Google App Engine
This is Rietveld 408576698