Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(88)

Unified Diff: LayoutTests/fast/dom/zoom-scroll-page-test.html

Issue 1301523006: Fixed layout tests to be scroll order agnostic (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: LayoutTests/fast/dom/zoom-scroll-page-test.html
diff --git a/LayoutTests/fast/dom/zoom-scroll-page-test.html b/LayoutTests/fast/dom/zoom-scroll-page-test.html
index 3b784181ca99844ad5edf12b1ce5b0fff9f062c5..3c8e28885d7d08c8ece4856c1076a16e34fc7fda 100644
--- a/LayoutTests/fast/dom/zoom-scroll-page-test.html
+++ b/LayoutTests/fast/dom/zoom-scroll-page-test.html
@@ -23,10 +23,10 @@
debug('Testing at zoom ' + zoomFactor + ' and scale ' + scaleFactor);
if (window.testRunner && window.eventSender && window.internals) {
var y = 221;
- internals.setPageScaleFactor(scaleFactor);
zoomBy(zoomFactor);
window.scrollTo(10, 10);
window.scrollBy(0, y);
+ internals.setPageScaleFactor(scaleFactor);
majidvp 2015/08/18 20:19:18 Don't scrollTo, scrollBy, and pageYOffset all oper
bokan 2015/08/19 17:10:45 Yup, you're right. This confused me for a bit so I
shouldBeCloseTo('window.pageYOffset', y+10, 3, false);
zoomBy(-zoomFactor);
}

Powered by Google App Engine
This is Rietveld 408576698