LayoutTests/fast/dom/zoom-scroll-page-test.html - Issue 1301523006: Fixed layout tests to be scroll order agnostic

Side by Side Diff: LayoutTests/fast/dom/zoom-scroll-page-test.html

Issue 1301523006: Fixed layout tests to be scroll order agnostic (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master

Patch Set: Created 5 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « LayoutTests/fast/dom/elementFromPoint-scaled-scrolled.html ('k') | LayoutTests/fast/events/touch/touch-scaled-scrolled.html » ('j') | LayoutTests/fast/events/touch/touch-scaled-scrolled.html » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 <!DOCTYPE html>	1 <!DOCTYPE html>

2 <html>	2 <html>

3 <head>	3 <head>

4 <style>	4 <style>

5 body { position: relative; height: 2000px; }	5 body { position: relative; height: 2000px; }

6 </style>	6 </style>

7 <script src="../../resources/js-test.js"></script>	7 <script src="../../resources/js-test.js"></script>

8 <script>	8 <script>

9 description('This tests that window.scrollBy respects the page\'s zoom a nd scale factor when scrolling.');	9 description('This tests that window.scrollBy respects the page\'s zoom a nd scale factor when scrolling.');

10	10

11 function zoomBy(zoomFactor)	11 function zoomBy(zoomFactor)

12 {	12 {

13 while (zoomFactor > 0) {	13 while (zoomFactor > 0) {

14 window.eventSender.zoomPageIn();	14 window.eventSender.zoomPageIn();

15 zoomFactor--;	15 zoomFactor--;

16 }	16 }

17 while (zoomFactor < 0) {	17 while (zoomFactor < 0) {

18 window.eventSender.zoomPageOut();	18 window.eventSender.zoomPageOut();

19 zoomFactor++;	19 zoomFactor++;

20 }	20 }

21 }	21 }

22 function testScroll(zoomFactor, scaleFactor) {	22 function testScroll(zoomFactor, scaleFactor) {

23 debug('Testing at zoom ' + zoomFactor + ' and scale ' + scaleFactor) ;	23 debug('Testing at zoom ' + zoomFactor + ' and scale ' + scaleFactor) ;

24 if (window.testRunner && window.eventSender && window.internals) {	24 if (window.testRunner && window.eventSender && window.internals) {

25 var y = 221;	25 var y = 221;

26 internals.setPageScaleFactor(scaleFactor);

27 zoomBy(zoomFactor);	26 zoomBy(zoomFactor);

28 window.scrollTo(10, 10);	27 window.scrollTo(10, 10);

29 window.scrollBy(0, y);	28 window.scrollBy(0, y);

	29 internals.setPageScaleFactor(scaleFactor);
	majidvp 2015/08/18 20:19:18 Don't scrollTo, scrollBy, and pageYOffset all oper Don't scrollTo, scrollBy, and pageYOffset all operate on visual viewport coordinate? So I would imagine that the order should not matter here? bokan 2015/08/19 17:10:45 Yup, you're right. This confused me for a bit so I Show quoted text On 2015/08/18 20:19:18, majidvp wrote: > Don't scrollTo, scrollBy, and pageYOffset all operate on visual viewport > coordinate? So I would imagine that the order should not matter here? Yup, you're right. This confused me for a bit so I dug into it. It turns out to be a floating point precision issue. When we scroll "layout first", the layout viewport has enough content that it consumes the whole scroll. Scrolling "visual first" splits the scroll between the viewports. Because of the way we handle fractional scroll values, this means there's two places with floating point imprecision so our error is increased (we truncate to ints twice). I think the right solution here is to bump the "nearness" value in shouldBeCloseTo from 3->4.
30 shouldBeCloseTo('window.pageYOffset', y+10, 3, false);	30 shouldBeCloseTo('window.pageYOffset', y+10, 3, false);

31 zoomBy(-zoomFactor);	31 zoomBy(-zoomFactor);

32 }	32 }

33 else	33 else

34 testFailed('This test only operates in DumpRenderTree.');	34 testFailed('This test only operates in DumpRenderTree.');

35 }	35 }

36	36

37 function runTests() {	37 function runTests() {

38 testScroll(-1,1.2);	38 testScroll(-1,1.2);

39 var zoomLevels = [-3, -2, -1, 0, 1, 3, 5];	39 var zoomLevels = [-3, -2, -1, 0, 1, 3, 5];

40 var scaleLevels = [0.75, 1, 1.2, 1.6];	40 var scaleLevels = [0.75, 1, 1.2, 1.6];

41 for (zoom in zoomLevels)	41 for (zoom in zoomLevels)

42 for (scale in scaleLevels)	42 for (scale in scaleLevels)

43 testScroll(zoomLevels[zoom], scaleLevels[scale]);	43 testScroll(zoomLevels[zoom], scaleLevels[scale]);

44	44

45 wasPostTestScriptParsed = true;	45 wasPostTestScriptParsed = true;

46 finishJSTest();	46 finishJSTest();

47 }	47 }

48 </script>	48 </script>

49 </head>	49 </head>

50	50

51 <body onload="runTests()">	51 <body onload="runTests()">

52 <div id="target"></div>	52 <div id="target"></div>

53 </body>	53 </body>

54 </html>	54 </html>

55	55

OLD	NEW