Issue 1301493002: Build icu with -Wno-unused-function.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1301493002: Build icu with -Wno-unused-function. (Closed)

Created:
5 years, 4 months ago by Nico

Modified:
5 years, 4 months ago

Reviewers:
jungshik at Google

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/chromium/deps/icu.git@master

Target Ref:
refs/heads/master

Visibility:
Public.

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+17 lines, -1 line)			Patch
	M	BUILD.gn	View		1 chunk	+13 lines, -0 lines	0 comments	Download
	M	icu.gyp	View		1 chunk	+4 lines, -1 line	0 comments	Download

Total messages: 5 (1 generated)

jungshik at Google

On 2015/08/17 20:04:46, Nico wrote: > ping Thanks. LGTM ucnv2022.cpp is fixed in the upstream ...

5 years, 4 months ago (2015-08-18 00:02:21 UTC) #4

Nico

5 years, 4 months ago (2015-08-18 00:04:05 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
89dcdec16381883782b9cc9cff38e00f047a0f46 (presubmit successful).