Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(312)

Side by Side Diff: BUILD.gn

Issue 1301493002: Build icu with -Wno-unused-function. (Closed) Base URL: https://chromium.googlesource.com/chromium/deps/icu.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | icu.gyp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 # Copyright 2014 The Chromium Authors. All rights reserved. 1 # Copyright 2014 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//third_party/icu/config.gni") 5 import("//third_party/icu/config.gni")
6 6
7 # Meta target that includes both icuuc and icui18n. Most targets want both. 7 # Meta target that includes both icuuc and icui18n. Most targets want both.
8 # You can depend on the individually if you need to. 8 # You can depend on the individually if you need to.
9 group("icu") { 9 group("icu") {
10 deps = [ 10 deps = [
(...skipping 49 matching lines...) Expand 10 before | Expand all | Expand 10 after
60 } else if (is_linux) { 60 } else if (is_linux) {
61 cflags += [ 61 cflags += [
62 # Since ICU wants to internally use its own deprecated APIs, don't 62 # Since ICU wants to internally use its own deprecated APIs, don't
63 # complain about it. 63 # complain about it.
64 "-Wno-deprecated-declarations", 64 "-Wno-deprecated-declarations",
65 "-Wno-unused-function", 65 "-Wno-unused-function",
66 ] 66 ]
67 } 67 }
68 if (is_clang) { 68 if (is_clang) {
69 cflags += [ 69 cflags += [
70 # ICU uses its own deprecated functions.
70 "-Wno-deprecated-declarations", 71 "-Wno-deprecated-declarations",
72 # ICU prefers `a && b || c` over `(a && b) || c`.
71 "-Wno-logical-op-parentheses", 73 "-Wno-logical-op-parentheses",
74 # ICU has some `unsigned < 0` checks.
72 "-Wno-tautological-compare", 75 "-Wno-tautological-compare",
76 # uresdata.c has switch(RES_GET_TYPE(x)) code. The
77 # RES_GET_TYPE macro returns an UResType enum, but some switch
78 # statement contains case values that aren't part of that
79 # enum (e.g. URES_TABLE32 which is in UResInternalType). This
80 # is on purpose.
73 "-Wno-switch", 81 "-Wno-switch",
82 # ICU has some code with the pattern:
83 # if (found = uprv_getWindowsTimeZoneInfo(...))
74 "-Wno-parentheses", 84 "-Wno-parentheses",
75 # ICU generally has no unused variables, but there are a few places where 85 # ICU generally has no unused variables, but there are a few places where
76 # this warning triggers. 86 # this warning triggers.
77 # See https://codereview.chromium.org/1222643002/ and 87 # See https://codereview.chromium.org/1222643002/ and
78 # http://www.icu-project.org/trac/ticket/11759. 88 # http://www.icu-project.org/trac/ticket/11759.
79 "-Wno-unused-const-variable", 89 "-Wno-unused-const-variable",
90 # ucnv2022.cpp contains three functions that are only used when
91 # certain preprocessor defines are set.
92 "-Wno-unused-function",
80 ] 93 ]
81 if (is_win) { 94 if (is_win) {
82 cflags += [ 95 cflags += [
83 # See http://bugs.icu-project.org/trac/ticket/11122 96 # See http://bugs.icu-project.org/trac/ticket/11122
84 "-Wno-inline-new-delete", 97 "-Wno-inline-new-delete",
85 "-Wno-implicit-exception-spec-mismatch", 98 "-Wno-implicit-exception-spec-mismatch",
86 # See http://bugs.icu-project.org/trac/ticket/11757. 99 # See http://bugs.icu-project.org/trac/ticket/11757.
87 "-Wno-reorder", 100 "-Wno-reorder",
88 ] 101 ]
89 } 102 }
(...skipping 480 matching lines...) Expand 10 before | Expand all | Expand 10 after
570 sources = [ 583 sources = [
571 "android/icudtl_dat.S", 584 "android/icudtl_dat.S",
572 ] 585 ]
573 } else { 586 } else {
574 assert(false, "No icu data for this platform") 587 assert(false, "No icu data for this platform")
575 } 588 }
576 defines = [ "U_HIDE_DATA_SYMBOL" ] 589 defines = [ "U_HIDE_DATA_SYMBOL" ]
577 } 590 }
578 } 591 }
579 } 592 }
OLDNEW
« no previous file with comments | « no previous file | icu.gyp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698