Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(352)

Issue 1301483002: Build libvpx with -Wno-unused-function. (Closed)

Created:
5 years, 4 months ago by Nico
Modified:
5 years, 4 months ago
Reviewers:
Johann, Tom Finegan
CC:
chromium-reviews, wwcv, jzern, fgalligan1, Tom Finegan
Base URL:
https://chromium.googlesource.com/chromium/deps/libvpx.git@master
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Build libvpx with -Wno-unused-function. Also make the gn config a bit more similar to the gyp config. BUG=505316 R=johannkoenig@google.com Committed: https://chromium.googlesource.com/chromium/deps/libvpx/+/3fe1b2a14e7693df172ded0fb08a4f1abc9247f4

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -11 lines) Patch
M BUILD.gn View 9 chunks +22 lines, -11 lines 0 comments Download
M libvpx.gyp View 1 chunk +2 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Nico
5 years, 4 months ago (2015-08-16 01:27:45 UTC) #2
Johann
LGTM
5 years, 4 months ago (2015-08-17 17:08:44 UTC) #4
Nico
5 years, 4 months ago (2015-08-17 17:16:46 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
3fe1b2a14e7693df172ded0fb08a4f1abc9247f4 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698