Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Issue 1301253002: Oilpan: have PromiseTracker callback keep a WeakPersistent<>. (Closed)

Created:
5 years, 4 months ago by sof
Modified:
5 years, 4 months ago
Reviewers:
oilpan-reviews, haraken
CC:
blink-reviews, caseq+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, pfeldman+blink_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, sergeyv+blink_chromium.org, kozyatinskiy+blink_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/blink.git@master
Target Ref:
refs/heads/master
Project:
blink
Visibility:
Public.

Description

Oilpan: have PromiseTracker callback keep a WeakPersistent<>. For the v8 callback objects that PromiseTrackers create, insist on using a WeakPersistent<> back reference to the PromiseTracker when Oilpan is enabled. R=haraken BUG=340522 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=200963

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -1 line) Patch
M Source/core/inspector/PromiseTracker.h View 1 chunk +2 lines, -0 lines 0 comments Download
M Source/core/inspector/PromiseTracker.cpp View 3 chunks +7 lines, -1 line 1 comment Download

Messages

Total messages: 7 (3 generated)
sof
please take a look.
5 years, 4 months ago (2015-08-20 21:20:28 UTC) #2
haraken
LGTM https://codereview.chromium.org/1301253002/diff/1/Source/core/inspector/PromiseTracker.cpp File Source/core/inspector/PromiseTracker.cpp (right): https://codereview.chromium.org/1301253002/diff/1/Source/core/inspector/PromiseTracker.cpp#newcode40 Source/core/inspector/PromiseTracker.cpp:40: m_tracker->m_listener->didUpdatePromise(InspectorFrontend::Debugger::EventType::Gc, promiseDetails.release()); This does complicated things like posting ...
5 years, 4 months ago (2015-08-21 00:16:25 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301253002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301253002/1
5 years, 4 months ago (2015-08-21 05:17:13 UTC) #6
commit-bot: I haz the power
5 years, 4 months ago (2015-08-21 05:21:23 UTC) #7
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://src.chromium.org/viewvc/blink?view=rev&revision=200963

Powered by Google App Engine
This is Rietveld 408576698