Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1051)

Unified Diff: Source/core/inspector/PromiseTracker.cpp

Issue 1301253002: Oilpan: have PromiseTracker callback keep a WeakPersistent<>. (Closed) Base URL: https://chromium.googlesource.com/chromium/blink.git@master
Patch Set: Created 5 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/inspector/PromiseTracker.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/inspector/PromiseTracker.cpp
diff --git a/Source/core/inspector/PromiseTracker.cpp b/Source/core/inspector/PromiseTracker.cpp
index c4830d5b812d74d4a16e48d5a51d0b45f7df9785..016c43be573531eacbf587d4f60b9ab9d37a9643 100644
--- a/Source/core/inspector/PromiseTracker.cpp
+++ b/Source/core/inspector/PromiseTracker.cpp
@@ -23,7 +23,11 @@ class PromiseTracker::PromiseWeakCallbackData final {
WTF_MAKE_NONCOPYABLE(PromiseWeakCallbackData);
public:
PromiseWeakCallbackData(PromiseTracker* tracker, int id)
+#if ENABLE(OILPAN)
+ : m_tracker(tracker)
+#else
: m_tracker(tracker->m_weakPtrFactory.createWeakPtr())
+#endif
, m_id(id)
{
}
@@ -36,7 +40,7 @@ public:
m_tracker->m_listener->didUpdatePromise(InspectorFrontend::Debugger::EventType::Gc, promiseDetails.release());
haraken 2015/08/21 00:16:25 This does complicated things like posting a messag
}
- WeakPtr<PromiseTracker> m_tracker;
+ WeakPtrWillBeWeakPersistent<PromiseTracker> m_tracker;
int m_id;
};
@@ -73,7 +77,9 @@ PromiseTracker::PromiseTracker(Listener* listener, v8::Isolate* isolate)
, m_captureStacks(false)
, m_listener(listener)
, m_isolate(isolate)
+#if !ENABLE(OILPAN)
, m_weakPtrFactory(this)
+#endif
, m_idToPromise(isolate)
{
clear();
« no previous file with comments | « Source/core/inspector/PromiseTracker.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698