Issue 1301203002: Revert "fill rect batch refactor into separate batches"

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1301203002: Revert "fill rect batch refactor into separate batches" (Closed)

Created:
5 years, 4 months ago by joshua.litt

Modified:
5 years, 4 months ago

Reviewers:
joshualitt

CC:
reviews_skia.org

Base URL:
https://skia.googlesource.com/skia.git@master

Target Ref:
refs/heads/master

Project:
skia

Visibility:
Public.

More Reviews

Description

Revert "fill rect batch refactor into separate batches" This reverts commit ae41b3834301444cf27b8aa729b8ad36666bdc08. TBR=bsalomon@google.com BUG=skia: Committed: https://skia.googlesource.com/skia/+/87e4752fc1f7b079a65208e4b3543925a35c3e54

Patch Set 1 #

Created: 5 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+208 lines, -252 lines)			Patch
M	src/gpu/batches/GrAAFillRectBatch.cpp	View	5 chunks	+15 lines, -20 lines	0 comments	Download
M	src/gpu/batches/GrBWFillRectBatch.cpp	View	3 chunks	+192 lines, -229 lines	0 comments	Download
M	src/gpu/batches/GrTInstanceBatch.h	View	2 chunks	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 3 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1301203002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1301203002/1

5 years, 4 months ago (2015-08-20 14:16:17 UTC) #2

commit-bot: I haz the power

5 years, 4 months ago (2015-08-20 14:22:46 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/87e4752fc1f7b079a65208e4b3543925a35c3e54

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages