Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(37)

Issue 13009007: Revert 190016 "Reland libjingle.gyp refactoring change." (Closed)

Created:
7 years, 9 months ago by tommi (sloooow) - chröme
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Revert 190016 "Reland libjingle.gyp refactoring change." > Reland libjingle.gyp refactoring change. > > Original description (from https://codereview.chromium.org/12457027/): > Refactor libjingle and libpeerconnection targets. > I'm moving most of the source files back to the libjingle target since the > current splitting doesn't work for all targets that currently rely on libjingle. > The webrtc core libs are still only in the libpeerconnection target, and > require the enable_webrtc gyp variable to be be set. > > I'm also adding a gyp variable to the libjingle target to support dependency > injection as is supported for libpeerconnection. > > TBR=ronghuawu@chromium.org > > Review URL: https://codereview.chromium.org/12967005 TBR=tommi@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190021

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+75 lines, -91 lines) Patch
M trunk/src/third_party/libjingle/libjingle.gyp View 7 chunks +75 lines, -91 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
7 years, 9 months ago (2013-03-23 16:24:20 UTC) #1
tommi (sloooow) - chröme
7 years, 9 months ago (2013-03-23 16:24:27 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 manually as r190021.

Powered by Google App Engine
This is Rietveld 408576698