Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(232)

Issue 12967005: libjingle.gyp (Closed)

Created:
7 years, 9 months ago by tommi (sloooow) - chröme
Modified:
7 years, 9 months ago
CC:
chromium-reviews
Base URL:
http://git.chromium.org/chromium/src.git@master
Visibility:
Public.

Description

Reland libjingle.gyp refactoring change. Original description (from https://codereview.chromium.org/12457027/): Refactor libjingle and libpeerconnection targets. I'm moving most of the source files back to the libjingle target since the current splitting doesn't work for all targets that currently rely on libjingle. The webrtc core libs are still only in the libpeerconnection target, and require the enable_webrtc gyp variable to be be set. I'm also adding a gyp variable to the libjingle target to support dependency injection as is supported for libpeerconnection. TBR=ronghuawu@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=190016

Patch Set 1 #

Patch Set 2 : Fix component build #

Patch Set 3 : workaround #

Patch Set 4 : remove workaround #

Unified diffs Side-by-side diffs Delta from patch set Stats (+91 lines, -75 lines) Patch
M third_party/libjingle/libjingle.gyp View 1 7 chunks +91 lines, -75 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
tommi (sloooow) - chröme
Hey Ronghua, I had to revert my previous CL due to issues on linux build ...
7 years, 9 months ago (2013-03-23 15:44:24 UTC) #1
tommi (sloooow) - chröme
7 years, 9 months ago (2013-03-23 15:59:45 UTC) #2
Message was sent while issue was closed.
Committed patchset #4 manually as r190016 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698