Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(116)

Issue 1300883003: Revert of Non-SFI mode: Add Linux asynchronous signal support (Closed)

Created:
5 years, 4 months ago by Luis Héctor Chávez
Modified:
5 years, 4 months ago
CC:
native-client-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/native_client/src/native_client.git@master
Target Ref:
refs/heads/master
Project:
nacl
Visibility:
Public.

Description

Revert of Non-SFI mode: Add Linux asynchronous signal support (patchset #12 id:220001 of https://codereview.chromium.org/1212613002/ ) Reason for revert: test_async_safe_signal seems to be broken on x86_32 bots, but not reproducible on trybots or local machine. Original issue's description: > Non-SFI mode: Add Linux asynchronous signal support > > This change adds a mechanism to both receive and send signals to other > threads in the process. A single signal is implemented with no option > to mask it, but user code can use this to multiplex multiple signals and > implement something that looks more like POSIX. > > Enabling signals will require allowing the tgkill system call (with the > current pid and SIGUSR1 as signum) and adding the CLONE_PARENT_SETTID > flag to clone. > > * Refactored some functions common to both signal and exception > handling from src/nonsfi/linux/irt_exception_handling.c to > src/nonsfi/linux/irt_signal_handling.c. That way, other code > can still call |nonsfi_initialize_signal_handler| and it will > install both. > * Added a test for user async-signals. > * Added documentation for this feature in > documentation/nonsfi_mode_async_signals.txt > > BUG=https://code.google.com/p/nativeclient/issues/detail?id=4065 > TEST=./scons run_user_async_signal_test_irt bitcode=1 nonsfi_nacl=1 \ > --mode=nacl,dbg-host,nacl_irt_test [platform=arm] > TEST=git try > > Committed: https://chromium.googlesource.com/native_client/src/native_client/+/6a0ce065f481a3eb0bcd63ed62755d82d339c617 TBR=mseaborn@chromium.org,uekawa@chromium.org NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=https://code.google.com/p/nativeclient/issues/detail?id=4065 Committed: https://chromium.googlesource.com/native_client/src/native_client/+/e73a2db66b7730fb7863b53839d071f6372fd71d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+323 lines, -1169 lines) Patch
M SConstruct View 1 chunk +0 lines, -1 line 0 comments Download
D documentation/nonsfi_mode_async_signals.txt View 1 chunk +0 lines, -55 lines 0 comments Download
M src/nonsfi/irt/irt.gyp View 1 chunk +1 line, -1 line 0 comments Download
M src/nonsfi/irt/irt_interfaces.c View 9 chunks +5 lines, -43 lines 0 comments Download
A src/nonsfi/linux/irt_exception_handling.c View 1 chunk +295 lines, -0 lines 0 comments Download
D src/nonsfi/linux/irt_signal_handling.h View 1 chunk +0 lines, -23 lines 0 comments Download
D src/nonsfi/linux/irt_signal_handling.c View 1 chunk +0 lines, -513 lines 0 comments Download
M src/nonsfi/linux/linux_pthread_private.h View 2 chunks +1 line, -2 lines 0 comments Download
M src/nonsfi/linux/linux_pthread_private.c View 4 chunks +6 lines, -23 lines 0 comments Download
M src/nonsfi/linux/linux_sys_private.h View 1 chunk +0 lines, -1 line 0 comments Download
M src/nonsfi/linux/linux_sys_private.c View 5 chunks +5 lines, -9 lines 0 comments Download
M src/nonsfi/linux/linux_syscall_defines.h View 1 chunk +1 line, -2 lines 0 comments Download
M src/nonsfi/linux/nacl.scons View 1 chunk +1 line, -1 line 0 comments Download
M src/public/linux_syscalls/sys/syscall.h View 2 chunks +0 lines, -4 lines 0 comments Download
M src/public/nonsfi/irt_exception_handling.h View 1 chunk +8 lines, -6 lines 0 comments Download
D src/public/nonsfi/irt_signal_handling.h View 1 chunk +0 lines, -22 lines 0 comments Download
M src/untrusted/irt/irt.h View 3 chunks +0 lines, -72 lines 0 comments Download
M tests/nonsfi/nacl.scons View 1 chunk +0 lines, -9 lines 0 comments Download
D tests/nonsfi/user_async_signal_test.cc View 1 chunk +0 lines, -382 lines 0 comments Download

Messages

Total messages: 9 (3 generated)
Luis Héctor Chávez
Created Revert of Non-SFI mode: Add Linux asynchronous signal support
5 years, 4 months ago (2015-08-19 22:13:46 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300883003/1
5 years, 4 months ago (2015-08-19 22:13:53 UTC) #2
commit-bot: I haz the power
No L-G-T-M from a valid reviewer yet. Only full committers are accepted. Even if an ...
5 years, 4 months ago (2015-08-19 22:13:55 UTC) #4
Derek Schuff
lgtm, thanks
5 years, 4 months ago (2015-08-19 22:15:04 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1300883003/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1300883003/1
5 years, 4 months ago (2015-08-19 22:17:23 UTC) #8
commit-bot: I haz the power
5 years, 4 months ago (2015-08-19 22:17:35 UTC) #9
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://chromium.googlesource.com/native_client/src/native_client/+/e73a2db66...

Powered by Google App Engine
This is Rietveld 408576698