Change width of rows in material design omnibox dropdown

chrome/browser/ui/views/omnibox/omnibox_result_view.h

Index: chrome/browser/ui/views/omnibox/omnibox_result_view.h
diff --git a/chrome/browser/ui/views/omnibox/omnibox_result_view.h b/chrome/browser/ui/views/omnibox/omnibox_result_view.h
index 9824e1081230ad6371fea41d01417893d23f49e5..ac95476c64e35b69969c2af562b9fc236104e0cd 100644
--- a/chrome/browser/ui/views/omnibox/omnibox_result_view.h
+++ b/chrome/browser/ui/views/omnibox/omnibox_result_view.h
@@ -172,6 +172,14 @@ class OmniboxResultView : public views::View,
                               int text_type,
                               bool is_bold);
 
+  // Returns the |left_margin_| and |right_margin_| members of
+  // OmniboxPopupContentsView if browser material design is enabled, and
+  // returns 0 otherwise. Used when laying out elements inside this view
+  // to ensure they are rendered within the region directly below the
+  // location bar.

[Peter Kasting, 2015/08/18 19:55:37]

Nit: How about:

Returns the necessary margin, if any, at the start and end of the view.  This
allows us to keep the icon and text in the view aligned with the location bar
constants.

(This avoids going into implementation details in an API comment.)

[tdanderson, 2015/08/19 17:22:35]

Done.

+  int LeftOffset() const;
+  int RightOffset() const;

[Peter Kasting, 2015/08/18 19:55:37]

I'd use "Margin" instead of "Offset" here, as a margin is a width and an offset
is a position.  These values are widths, not positions.

I'd also try to avoid "left" and "right" and prefer "Start" and "End" if
possible, though perhaps that change only makes sense when you fix this for RTL?

[tdanderson, 2015/08/19 17:22:35]

Done.
I was planning on addressing that if needed when looking at RTL. I picked "left"
and "right" to be consistent with the naming of |left_margin_| and
|right_margin_|.

+
   static int default_icon_size_;
 
   // This row's model and model index.